* [PATCH] V4L: s5c73m3: Add format propagation for TRY formats
@ 2013-07-24 14:57 Sylwester Nawrocki
2013-08-08 22:58 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Sylwester Nawrocki @ 2013-07-24 14:57 UTC (permalink / raw)
To: linux-media; +Cc: Andrzej Hajda, Kyungmin Park, Sylwester Nawrocki
From: Andrzej Hajda <a.hajda@samsung.com>
Resolution set on ISP pad of S5C73M3-OIF subdev should be
propagated to source pad for TRY and ACTIVE formats.
The patch adds missing propagation for TRY format.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
index 825ea86..b76ec0e 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
@@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev *sd,
if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
mf = v4l2_subdev_get_try_format(fh, fmt->pad);
*mf = fmt->format;
+ if (fmt->pad == OIF_ISP_PAD) {
+ mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD);
+ mf->width = fmt->format.width;
+ mf->height = fmt->format.height;
+ }
} else {
switch (fmt->pad) {
case OIF_ISP_PAD:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] V4L: s5c73m3: Add format propagation for TRY formats
2013-07-24 14:57 [PATCH] V4L: s5c73m3: Add format propagation for TRY formats Sylwester Nawrocki
@ 2013-08-08 22:58 ` Laurent Pinchart
2013-08-09 6:24 ` Andrzej Hajda
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2013-08-08 22:58 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: linux-media, Andrzej Hajda, Kyungmin Park
Hello,
On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote:
> From: Andrzej Hajda <a.hajda@samsung.com>
>
> Resolution set on ISP pad of S5C73M3-OIF subdev should be
> propagated to source pad for TRY and ACTIVE formats.
> The patch adds missing propagation for TRY format.
I might be missing something, but where's the propagation for the ACTIVE
format ?
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev
> *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> mf = v4l2_subdev_get_try_format(fh, fmt->pad);
> *mf = fmt->format;
> + if (fmt->pad == OIF_ISP_PAD) {
> + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD);
> + mf->width = fmt->format.width;
> + mf->height = fmt->format.height;
> + }
> } else {
> switch (fmt->pad) {
> case OIF_ISP_PAD:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] V4L: s5c73m3: Add format propagation for TRY formats
2013-08-08 22:58 ` Laurent Pinchart
@ 2013-08-09 6:24 ` Andrzej Hajda
2013-08-09 10:19 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Andrzej Hajda @ 2013-08-09 6:24 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Sylwester Nawrocki, linux-media, Kyungmin Park
Hi Laurent,
Thank you for the review.
On 08/09/2013 12:58 AM, Laurent Pinchart wrote:
> Hello,
>
> On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote:
>> From: Andrzej Hajda <a.hajda@samsung.com>
>>
>> Resolution set on ISP pad of S5C73M3-OIF subdev should be
>> propagated to source pad for TRY and ACTIVE formats.
>> The patch adds missing propagation for TRY format.
> I might be missing something, but where's the propagation for the ACTIVE
> format ?
In case of active format there are no separate containers
for the format of each pad, instead they shares common fields,
precisely .oif_pix_size and .mbus_code.
This way there is no need for extra code for format propagation.
Regards
Andrzej
>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> ---
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644
>> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev
>> *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
>> mf = v4l2_subdev_get_try_format(fh, fmt->pad);
>> *mf = fmt->format;
>> + if (fmt->pad == OIF_ISP_PAD) {
>> + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD);
>> + mf->width = fmt->format.width;
>> + mf->height = fmt->format.height;
>> + }
>> } else {
>> switch (fmt->pad) {
>> case OIF_ISP_PAD:
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] V4L: s5c73m3: Add format propagation for TRY formats
2013-08-09 6:24 ` Andrzej Hajda
@ 2013-08-09 10:19 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2013-08-09 10:19 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: Sylwester Nawrocki, linux-media, Kyungmin Park
Hi Andrzej,
On Friday 09 August 2013 08:24:10 Andrzej Hajda wrote:
> On 08/09/2013 12:58 AM, Laurent Pinchart wrote:
> > On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote:
> >> From: Andrzej Hajda <a.hajda@samsung.com>
> >>
> >> Resolution set on ISP pad of S5C73M3-OIF subdev should be
> >> propagated to source pad for TRY and ACTIVE formats.
> >> The patch adds missing propagation for TRY format.
> >
> > I might be missing something, but where's the propagation for the ACTIVE
> > format ?
>
> In case of active format there are no separate containers
> for the format of each pad, instead they shares common fields,
> precisely .oif_pix_size and .mbus_code.
> This way there is no need for extra code for format propagation.
I got confused by the s5c73m3_oif_get_fmt() implementation that retrieves the
pixel code and frame size from different internal state fields for the soruce
pad. The code looks correct.
> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >> ---
> >>
> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> >> b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644
> >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> >> @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev
> >> *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> >>
> >> mf = v4l2_subdev_get_try_format(fh, fmt->pad);
> >> *mf = fmt->format;
> >>
> >> + if (fmt->pad == OIF_ISP_PAD) {
> >> + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD);
> >> + mf->width = fmt->format.width;
> >> + mf->height = fmt->format.height;
> >> + }
> >>
> >> } else {
> >>
> >> switch (fmt->pad) {
> >> case OIF_ISP_PAD:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-09 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-24 14:57 [PATCH] V4L: s5c73m3: Add format propagation for TRY formats Sylwester Nawrocki
2013-08-08 22:58 ` Laurent Pinchart
2013-08-09 6:24 ` Andrzej Hajda
2013-08-09 10:19 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox