public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Bialonczyk <manio@skyboo.net>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Chris Lee <updatelee@gmail.com>
Subject: Re: stv090x vs stv0900 support
Date: Fri, 16 Aug 2013 09:19:27 +0200	[thread overview]
Message-ID: <520DD27F.8020708@skyboo.net> (raw)
In-Reply-To: <CAA9z4Lbd5wm0=T=CGHbxga5wOdj+TZQO2BA+spxV_keWS5OmcQ@mail.gmail.com>

On 07/24/2013 06:39 PM, Chris Lee wrote:
> Im looking for comments on these two modules, they overlap support for
> the same demods. stv0900 supporting stv0900 and stv090x supporting
> stv0900 and stv0903. Ive flipped a few cards from one to the other and
> they function fine. In some ways stv090x is better suited. Its a pain
> supporting two modules that are written differently but do the same
> thing, a fix in one almost always means it has to be implemented in
> the other as well.
I totally agree with you.

> Im not necessarily suggesting dumping stv0900, but Id like to flip a
> few cards that I own over to stv090x just to standardize it. The Prof
> 7301 and Prof 7500.
I did it already for 7301, see here:
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/28082
but due to 'political' reasons it doesn't went upstream.
For private use i am still using this patch on recent kernels, because
it is working much more stable for my card comparing to stv0900.
I think that moving prof 7500 should be relative easy, i even prepared
a patch for this but I was not able to test it due to lack of hardware.

> Whats everyones thoughts on this? It will cut the number of patch''s
> in half when it comes to these demods. Ive got alot more coming lol :)
Oh yes, you could also take into account another duplicate code:
stb6100_cfg.h used for stv090x
stb6100_proc.h used for stv0900
In my patch I've successfully switched to stb6100_cfg.h.
> 
> Chris
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

regards,
-- 
Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net
http://manio.skyboo.net | https://github.com/manio


  parent reply	other threads:[~2013-08-16  7:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 16:39 stv090x vs stv0900 support Chris Lee
2013-07-24 17:21 ` Krishna Kishore
2013-07-24 17:52   ` Antti Palosaari
2013-07-24 21:56     ` Oliver Schinagl
2013-08-16  7:19 ` Mariusz Bialonczyk [this message]
2013-08-16 12:50   ` Chris Lee
2013-08-27  7:19     ` Krishna Kishore
2013-08-28 12:35       ` Krishna Kishore
2013-08-29 15:20         ` Krishna Kishore
2013-08-29 15:43           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520DD27F.8020708@skyboo.net \
    --to=manio@skyboo.net \
    --cc=linux-media@vger.kernel.org \
    --cc=updatelee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox