From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: linux-media@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file
Date: Mon, 19 Aug 2013 09:15:20 +0200 [thread overview]
Message-ID: <5211C608.60201@xs4all.nl> (raw)
In-Reply-To: <1376856050-30538-1-git-send-email-s.nawrocki@samsung.com>
On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote:
> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"
>
> This fixes following build error:
>
> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’
>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
My apologies for missing this one.
Regards,
Hans
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> drivers/media/platform/s5p-tv/hdmi_drv.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c
> index 1b34c36..f9af2c2 100644
> --- a/drivers/media/platform/s5p-tv/hdmi_drv.c
> +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c
> @@ -37,6 +37,7 @@
> #include <media/v4l2-common.h>
> #include <media/v4l2-dev.h>
> #include <media/v4l2-device.h>
> +#include <media/v4l2-dv-timings.h>
>
> #include "regs-hdmi.h"
>
>
next prev parent reply other threads:[~2013-08-19 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 20:00 [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file Sylwester Nawrocki
2013-08-19 7:15 ` Hans Verkuil [this message]
2013-08-21 8:25 ` Sylwester Nawrocki
2013-08-21 8:38 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5211C608.60201@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox