[PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file

[PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file

[Sylwester Nawrocki]

Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
"[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"

This fixes following build error:

drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’

Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 drivers/media/platform/s5p-tv/hdmi_drv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c
index 1b34c36..f9af2c2 100644
--- a/drivers/media/platform/s5p-tv/hdmi_drv.c
+++ b/drivers/media/platform/s5p-tv/hdmi_drv.c
@@ -37,6 +37,7 @@
 #include <media/v4l2-common.h>
 #include <media/v4l2-dev.h>
 #include <media/v4l2-device.h>
+#include <media/v4l2-dv-timings.h>
 
 #include "regs-hdmi.h"
 
-- 
1.7.4.1

Re: [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file

[Hans Verkuil]

On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote:
> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"
> 
> This fixes following build error:
> 
> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’
> 
> Cc: Hans Verkuil <hans.verkuil@cisco.com>

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

My apologies for missing this one.

Regards,

	Hans

> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  drivers/media/platform/s5p-tv/hdmi_drv.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c
> index 1b34c36..f9af2c2 100644
> --- a/drivers/media/platform/s5p-tv/hdmi_drv.c
> +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c
> @@ -37,6 +37,7 @@
>  #include <media/v4l2-common.h>
>  #include <media/v4l2-dev.h>
>  #include <media/v4l2-device.h>
> +#include <media/v4l2-dv-timings.h>
>  
>  #include "regs-hdmi.h"
>  
> 

Re: [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file

[Sylwester Nawrocki]

Hi Hans,

On 08/19/2013 09:15 AM, Hans Verkuil wrote:
> On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote:
>> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
>> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
>> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"
>>
>> This fixes following build error:
>>
>> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
>> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’
>>
>> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> My apologies for missing this one.

That's all right. Shit happens. I was wondering why this error
didn't show up in your daily builds.

--
Regards,
Sylwester

Re: [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file

[Hans Verkuil]

On Wed 21 August 2013 10:25:18 Sylwester Nawrocki wrote:
> Hi Hans,
> 
> On 08/19/2013 09:15 AM, Hans Verkuil wrote:
> > On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote:
> >> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
> >> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
> >> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"
> >>
> >> This fixes following build error:
> >>
> >> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
> >> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’
> >>
> >> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > 
> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> > 
> > My apologies for missing this one.
> 
> That's all right. Shit happens. I was wondering why this error
> didn't show up in your daily builds.

I had a local patch for that and I forgot to remove it. So next time it will
show up as an error again.

Regards,

	Hans