From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH v7] s5k5baf: add camera sensor driver
Date: Fri, 23 Aug 2013 11:23:31 +0200 [thread overview]
Message-ID: <52172A13.1080701@samsung.com> (raw)
In-Reply-To: <9243520.EzMBhpL3jX@flatron>
On 08/23/2013 12:39 AM, Tomasz Figa wrote:
>> Documentation/devicetree/bindings/media/samsung-s5k5baf.txt create mode
>> > 100644 drivers/media/i2c/s5k5baf.c
>> >
>> > diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt
>> > b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt new file
>> > mode 100644
>> > index 0000000..d680d99
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt
>> > @@ -0,0 +1,59 @@
>> > +Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor with embedded SoC ISP
>> > +--------------------------------------------------------------------
>> > +
>> > +Required properties:
>> > +
>> > +- compatible : "samsung,s5k5baf";
>> > +- reg : I2C slave address of the sensor;
>
> Can this sensor have an aribitrary slave address or only a set of well
> known possible addresses (e.g. listed in documentation)?
According to the datasheet it can have one of two I2C addresses (0x2D, 0x3C),
selectable by a dedicated pin. Also they may be revisions of the device that
use different addresses. I believe what addresses are possible is out of
scope of this binding document. We can handle whatever is used.
>> > +- vdda-supply : analog power supply 2.8V (2.6V to 3.0V);
>> > +- vddreg-supply : regulator input power supply 1.8V (1.7V to
> 1.9V)
>> > + or 2.8V (2.6V to 3.0);
>> > +- vddio-supply : I/O power supply 1.8V (1.65V to 1.95V)
>> > + or 2.8V (2.5V to 3.1V);
>> > +- stbyn-gpios : GPIO connected to STDBYN pin;
>> > +- rstn-gpios : GPIO connected to RSTN pin;
>
> Both GPIOs above have names suggesting that they are active low. I wonder
> how the GPIO flags cell is interpreted here, namely the polarity bit.
That's a good point. The GPIO flags are be used to specify active state
of the GPIO. Some sensors happen to use different active state for those
signals. It's not the case for this sensor though AFAICT.
Anyway IMO it would be better to name those gpios: "stby-gpios",
"rst-gpios" in case there appear revisions that have their pin named STDBY
or RST rather than STDBYN, RSTN. That seems rather unlikely though, but
since there are devices to which that could apply I think for consistency
it might be better to remove indication of polarity from the GPIO names.
next prev parent reply other threads:[~2013-08-23 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 14:41 [PATCH v7] s5k5baf: add camera sensor driver Andrzej Hajda
2013-08-22 20:01 ` Stephen Warren
2013-08-22 22:39 ` Tomasz Figa
2013-08-23 9:23 ` Sylwester Nawrocki [this message]
2013-08-23 9:48 ` Sylwester Nawrocki
2013-08-23 9:48 ` Pawel Moll
2013-08-23 12:53 ` Laurent Pinchart
2013-08-26 12:34 ` Andrzej Hajda
2013-08-27 11:52 ` Laurent Pinchart
2013-08-27 9:14 ` Mark Rutland
2013-09-02 16:21 ` Sylwester Nawrocki
2013-09-02 16:55 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52172A13.1080701@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox