From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:31673 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753071Ab3H0O0K (ORCPT ); Tue, 27 Aug 2013 10:26:10 -0400 Message-id: <521CB6FF.70401@samsung.com> Date: Tue, 27 Aug 2013 16:26:07 +0200 From: Sylwester Nawrocki MIME-version: 1.0 To: Dan Carpenter Cc: Sylwester Nawrocki , linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface References: <20130823094647.GO31293@elgon.mountain> <5219F736.2010706@gmail.com> <20130827141914.GD19256@mwanda> In-reply-to: <20130827141914.GD19256@mwanda> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/27/2013 04:19 PM, Dan Carpenter wrote: > On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki wrote: >> On 08/23/2013 11:46 AM, Dan Carpenter wrote: >>> [ Going through some old warnings... ] >>> >>> Hello Sylwester Nawrocki, >>> >>> This is a semi-automatic email about new static checker warnings. >>> >>> The patch babde1c243b2: "[media] V4L: Add driver for S3C24XX/S3C64XX >>> SoC series camera interface" from Aug 22, 2012, leads to the >>> following Smatch complaint: >>> >>> drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup() >>> warn: variable dereferenced before check 'fmt' (see line 460) >>> >>> drivers/media/platform/s3c-camif/camif-capture.c >>> 455 if (pfmt) { >>> 456 pix =&pfmt->fmt.pix; >>> 457 fmt = s3c_camif_find_format(vp,&pix->pixelformat, -1); >>> 458 size = (pix->width * pix->height * fmt->depth) / 8; >>> ^^^^^^^^^^ >>> Dereference. >>> >>> 459 } else { >>> 460 size = (frame->f_width * frame->f_height * fmt->depth) / 8; >>> ^^^^^^^^^^ >>> Dereference. >>> >>> 461 } >>> 462 >>> 463 if (fmt == NULL) >>> ^^^^^^^^^^^ >>> Check. >> >> Thanks for the bug report. This check of course should be before line 455. >> Would you like to sent a patch for this or should I handle that ? > > Could you handle it and give me the Reported-by tag? Sure, will do. -- Regards, Sylwester