[PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB

[PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB

[Chen Gang]

DVB_B2C2_FLEXCOP_USB need depend on PCI, or can not pass compiling with
allmodconfig for h8300.

The related error:

  drivers/media/usb/b2c2/flexcop-usb.c: In function 'flexcop_usb_transfer_exit':
  drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function 'pci_free_consistent' [-Werror=implicit-function-declaration]
     pci_free_consistent(NULL,
     ^
  drivers/media/usb/b2c2/flexcop-usb.c: In function 'flexcop_usb_transfer_init':
  drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function 'pci_alloc_consistent' [-Werror=implicit-function-declaration]
    fc_usb->iso_buffer = pci_alloc_consistent(NULL,
    ^
  drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
    fc_usb->iso_buffer = pci_alloc_consistent(NULL,
                       ^
  cc1: some warnings being treated as errors


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 drivers/media/usb/b2c2/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/usb/b2c2/Kconfig b/drivers/media/usb/b2c2/Kconfig
index 17d3583..06fdf30 100644
--- a/drivers/media/usb/b2c2/Kconfig
+++ b/drivers/media/usb/b2c2/Kconfig
@@ -1,6 +1,6 @@
 config DVB_B2C2_FLEXCOP_USB
 	tristate "Technisat/B2C2 Air/Sky/Cable2PC USB"
-	depends on DVB_CORE && I2C
+	depends on DVB_CORE && I2C && PCI
 	help
 	  Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by Technisat/B2C2,
 
-- 
1.7.7.6

Re: [PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB

[Chen Gang]

On 08/30/2013 04:06 PM, Patrick Boettcher wrote:
> Hi,
> 
>  
> 
> On Friday 30 August 2013 10:23:24 Chen Gang wrote:
> 
>> DVB_B2C2_FLEXCOP_USB need depend on PCI, or can not pass compiling with
> 
>> allmodconfig for h8300.
> 
>>
> 
>> The related error:
> 
>>
> 
>> drivers/media/usb/b2c2/flexcop-usb.c: In function
> 
>> 'flexcop_usb_transfer_exit': drivers/media/usb/b2c2/flexcop-usb.c:393:3:
> 
>> error: implicit declaration of function 'pci_free_consistent'
> 
>> [-Werror=implicit-function-declaration] pci_free_consistent(NULL,
> 
>>
> 
>> [..]
> 
>>
> 
>> config DVB_B2C2_FLEXCOP_USB
> 
>> tristate "Technisat/B2C2 Air/Sky/Cable2PC USB"
> 
>> - depends on DVB_CORE && I2C
> 
>> + depends on DVB_CORE && I2C && PCI
> 
>> help
> 
>> Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by
> 
>> Technisat/B2C2,
> 
>  
> 
> Instead of selecting PCI we could/should use usb_alloc_coherent() and
> usb_free_cohrerent(), shouldn't we?
> 

Hmm... maybe it is a good idea, but I am just trying another ways.

Just now, I find that the module which calls pci*consistent() may not be
pci dependent module (e.g. may depend on ISA or EISA instead of).

So "arch/h8300/include/asm/pci.h" has related issues, I am just fixing.

Maybe our case is not an issue, after "asm/pci.h" fixed (although for
our case only, it can be improved, too, and if you are sure about it,
please help improving it, thanks).

>  
> 
> --
> 
> Patrick
> 


Thanks.
-- 
Chen Gang

Re: [PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB

[Patrick Boettcher]

Hi (sending again due to HTML-nonsense in Mail),

On Friday 30 August 2013 10:23:24 Chen Gang wrote:
> DVB_B2C2_FLEXCOP_USB need depend on PCI, or can not pass compiling with
> allmodconfig for h8300.
> 
> The related error:
> 
>   drivers/media/usb/b2c2/flexcop-usb.c: In function
> 'flexcop_usb_transfer_exit': drivers/media/usb/b2c2/flexcop-usb.c:393:3:
> error: implicit declaration of function 'pci_free_consistent'
> [-Werror=implicit-function-declaration] pci_free_consistent(NULL,
> 
> [..]
> 
>  config DVB_B2C2_FLEXCOP_USB
>  	tristate "Technisat/B2C2 Air/Sky/Cable2PC USB"
> -	depends on DVB_CORE && I2C
> +	depends on DVB_CORE && I2C && PCI
>  	help
>  	  Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by
> Technisat/B2C2,

Instead of selecting PCI we could/should use usb_alloc_coherent() and 
usb_free_cohrerent(), shouldn't we?

--
Patrick