From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:19013 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466Ab3H3Lcg (ORCPT ); Fri, 30 Aug 2013 07:32:36 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MSC00D1ADD21O00@mailout1.w1.samsung.com> for linux-media@vger.kernel.org; Fri, 30 Aug 2013 12:32:34 +0100 (BST) Message-id: <522082D1.1080206@samsung.com> Date: Fri, 30 Aug 2013 13:32:33 +0200 From: Sylwester Nawrocki MIME-version: 1.0 To: Sachin Kamat Cc: linux-media@vger.kernel.org, hans.verkuil@cisco.com, patches@linaro.org Subject: Re: [PATCH 1/1] [media] v4l2-ctrls: Remove duplicate const References: <1377861082-17312-1-git-send-email-sachin.kamat@linaro.org> In-reply-to: <1377861082-17312-1-git-send-email-sachin.kamat@linaro.org> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sachin, On 08/30/2013 01:11 PM, Sachin Kamat wrote: > The function returns a pointer to a const array. Duplicate use of const > led to the following warning. > drivers/media/v4l2-core/v4l2-ctrls.c:574:32: warning: duplicate const > > Signed-off-by: Sachin Kamat > Cc: Sylwester Nawrocki Thanks for the patch. I have already submitted a fix for this: https://patchwork.linuxtv.org/patch/19902/ Regards, Sylwester > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 6 +++--- > include/media/v4l2-common.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > index c6dc1fd..653d48d 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -565,13 +565,13 @@ EXPORT_SYMBOL(v4l2_ctrl_get_menu); > * Returns NULL or an s64 type array containing the menu for given > * control ID. The total number of the menu items is returned in @len. > */ > -const s64 const *v4l2_ctrl_get_int_menu(u32 id, u32 *len) > +const s64 *v4l2_ctrl_get_int_menu(u32 id, u32 *len) > { > - static const s64 const qmenu_int_vpx_num_partitions[] = { > + static const s64 qmenu_int_vpx_num_partitions[] = { > 1, 2, 4, 8, > }; > > - static const s64 const qmenu_int_vpx_num_ref_frames[] = { > + static const s64 qmenu_int_vpx_num_ref_frames[] = { > 1, 2, 3, > }; > > diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h > index 16550c4..b87692c 100644 > --- a/include/media/v4l2-common.h > +++ b/include/media/v4l2-common.h > @@ -86,7 +86,7 @@ int v4l2_ctrl_check(struct v4l2_ext_control *ctrl, struct v4l2_queryctrl *qctrl, > const char * const *menu_items); > const char *v4l2_ctrl_get_name(u32 id); > const char * const *v4l2_ctrl_get_menu(u32 id); > -const s64 const *v4l2_ctrl_get_int_menu(u32 id, u32 *len); > +const s64 *v4l2_ctrl_get_int_menu(u32 id, u32 *len); > int v4l2_ctrl_query_fill(struct v4l2_queryctrl *qctrl, s32 min, s32 max, s32 step, s32 def); > int v4l2_ctrl_query_menu(struct v4l2_querymenu *qmenu, > struct v4l2_queryctrl *qctrl, const char * const *menu_items); > -- Sylwester Nawrocki Samsung R&D Institute Poland