From: Antti Palosaari <crope@iki.fi>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: linux-media@vger.kernel.org, Jacek Konieczny <jajcus@jajcus.net>,
Torsten Seyffarth <t.seyffarth@gmx.de>,
Jan Taegert <jantaegert@gmx.net>,
Damien CABROL <cabrol.damien@free.fr>
Subject: Re: [PATCH] e4000: fix PLL calc error in 32-bit arch
Date: Mon, 02 Sep 2013 19:26:21 +0300 [thread overview]
Message-ID: <5224BC2D.2040909@iki.fi> (raw)
In-Reply-To: <1378138669-22302-1-git-send-email-crope@iki.fi>
Testers?
Here is tree:
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/e4000_fix_3.11
I assume all of you have been running 32-bit arch as that bug is related
to 32-bit overflow.
regards
Antti
On 09/02/2013 07:17 PM, Antti Palosaari wrote:
> Fix long-lasting error that causes tuning failure to some frequencies
> on 32-bit arch.
>
> Special thanks goes to Damien CABROL who finally find root of the bug.
> Also big thanks to Jacek Konieczny for donating non-working device.
>
> Reported-by: Jacek Konieczny <jajcus@jajcus.net>
> Reported-by: Torsten Seyffarth <t.seyffarth@gmx.de>
> Reported-by: Jan Taegert <jantaegert@gmx.net>
> Reported-by: Damien CABROL <cabrol.damien@free.fr>
> Tested-by: Damien CABROL <cabrol.damien@free.fr>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/tuners/e4000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/tuners/e4000.c b/drivers/media/tuners/e4000.c
> index 1b33ed3..a88f757 100644
> --- a/drivers/media/tuners/e4000.c
> +++ b/drivers/media/tuners/e4000.c
> @@ -232,7 +232,7 @@ static int e4000_set_params(struct dvb_frontend *fe)
> * or more.
> */
> f_VCO = c->frequency * e4000_pll_lut[i].mul;
> - sigma_delta = 0x10000UL * (f_VCO % priv->cfg->clock) / priv->cfg->clock;
> + sigma_delta = div_u64(0x10000ULL * (f_VCO % priv->cfg->clock), priv->cfg->clock);
> buf[0] = f_VCO / priv->cfg->clock;
> buf[1] = (sigma_delta >> 0) & 0xff;
> buf[2] = (sigma_delta >> 8) & 0xff;
>
--
http://palosaari.fi/
next parent reply other threads:[~2013-09-02 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378138669-22302-1-git-send-email-crope@iki.fi>
2013-09-02 16:26 ` Antti Palosaari [this message]
2013-09-02 19:08 ` [PATCH] e4000: fix PLL calc error in 32-bit arch Jan Taegert
2013-09-02 19:14 ` Jacek Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5224BC2D.2040909@iki.fi \
--to=crope@iki.fi \
--cc=cabrol.damien@free.fr \
--cc=jajcus@jajcus.net \
--cc=jantaegert@gmx.net \
--cc=linux-media@vger.kernel.org \
--cc=t.seyffarth@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox