From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from foss.arm.com ([217.140.101.70]:51998 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbeKZRiN (ORCPT ); Mon, 26 Nov 2018 12:38:13 -0500 Subject: Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE To: Vinod Koul Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-media@vger.kernel.org, iommu@lists.linux-foundation.org, linux-rdma@vger.kernel.org, dmaengine@vger.kernel.org, linux-block@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-alpha@vger.kernel.org, akpm@linux-foundation.org, jiangqi903@gmail.com, hverkuil@xs4all.nl References: <1542966856-12619-1-git-send-email-anshuman.khandual@arm.com> <20181124140554.GG3175@vkoul-mobl.Dlink> From: Anshuman Khandual Message-ID: <5228bcdb-b140-a86a-6c9c-488f1a723353@arm.com> Date: Mon, 26 Nov 2018 12:15:04 +0530 MIME-Version: 1.0 In-Reply-To: <20181124140554.GG3175@vkoul-mobl.Dlink> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 11/24/2018 07:35 PM, Vinod Koul wrote: > On 23-11-18, 15:24, Anshuman Khandual wrote: > >> --- a/drivers/dma/dmaengine.c >> +++ b/drivers/dma/dmaengine.c >> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all); >> static bool dma_chan_is_local(struct dma_chan *chan, int cpu) >> { >> int node = dev_to_node(chan->device->dev); >> - return node == -1 || cpumask_test_cpu(cpu, cpumask_of_node(node)); >> + return node == NUMA_NO_NODE || >> + cpumask_test_cpu(cpu, cpumask_of_node(node)); >> } > > I do not see dev_to_node being updated first, that returns -1 so I would > prefer to check for -1 unless it return NUMA_NO_NODE Sure will update dev_to_node() to return NUMA_NO_NODE as well.