From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42260 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757455AbaITTcA (ORCPT ); Sat, 20 Sep 2014 15:32:00 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, m.chehab@samsung.com Subject: Re: [PATCHv2 0/3] vb2: fix VBI/poll regression Date: Sat, 20 Sep 2014 22:32:06 +0300 Message-ID: <5243534.RniG8ZRvhe@avalon> In-Reply-To: <1411240597-2105-1-git-send-email-hverkuil@xs4all.nl> References: <1411240597-2105-1-git-send-email-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thank you for the patches. Acked-by: Laurent Pinchart On Saturday 20 September 2014 21:16:34 Hans Verkuil wrote: > OK, so v1 wasn't the final patch series :-) Let's see if this is. > > Changes since v1: > > - Also initialize waiting_for_buffers in STREAMOFF and when CREATE_BUFS is > called and no buffers have been allocated yet. > - Improve some of the wording in patch 2 based on suggestions from Laurent. > > This patch series resolves the vb2 VBI poll regression where alevt and mtt > fail on drivers using vb2. > > These applications call REQBUFS, queue the buffers and then poll() without > calling STREAMON first. They rely on poll() to return POLLERR in that case > and they do the STREAMON at that time. This is correct according to the > spec, but this was never implemented in vb2. > > This is fixed together with an other vb2 regression: calling REQBUFS, then > STREAMON, then poll() without doing a QBUF first should return POLLERR as > well according to the spec. This has been fixed as well and the spec has > been clarified that this is only done for capture queues. Output queues in > the same situation will return as well, but with POLLOUT|POLLWRNORM set > instead of POLLERR. > > The final patch adds missing documentation to poll() regarding event > handling and improves the documentation regarding stream I/O and output > queues. > > Regards, > > Hans -- Regards, Laurent Pinchart