Re: [PATCH 00/10] [media] remove unnecessary pci_set_drvdata()

Re: [PATCH 00/10] [media] remove unnecessary pci_set_drvdata()

[Hans Verkuil]

On 09/23/2013 03:43 AM, Jingoo Han wrote:
> Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound),
> the driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.

For the whole patch series:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

> 
> ---
>  drivers/media/common/saa7146/saa7146_core.c |    2 --
>  drivers/media/pci/b2c2/flexcop-pci.c        |    2 --
>  drivers/media/pci/bt8xx/bt878.c             |    1 -
>  drivers/media/pci/cx88/cx88-alsa.c          |    2 --
>  drivers/media/pci/cx88/cx88-mpeg.c          |    1 -
>  drivers/media/pci/cx88/cx88-video.c         |    1 -
>  drivers/media/pci/dm1105/dm1105.c           |    2 --
>  drivers/media/pci/mantis/mantis_pci.c       |    2 --
>  drivers/media/pci/ngene/ngene-core.c        |    2 --
>  drivers/media/pci/pluto2/pluto2.c           |    2 --
>  drivers/media/pci/pt1/pt1.c                 |    2 --
>  drivers/media/pci/saa7164/saa7164-core.c    |    1 -
>  12 files changed, 20 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 00/10] [media] remove unnecessary pci_set_drvdata()

[Sachin Kamat]

Hi Hans,

On 30 September 2013 17:52, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 09/23/2013 03:43 AM, Jingoo Han wrote:
>> Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
>> (device-core: Ensure drvdata = NULL when no driver is bound),
>> the driver core clears the driver data to NULL after device_release
>> or on probe failure. Thus, it is not needed to manually clear the
>> device driver data to NULL.
>
> For the whole patch series:
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>

I had sent a similar series (3 days) earlier to Jingoo's  [1]. I hope
to get your ack for that one instead.

[1] http://www.spinics.net/lists/linux-media/msg68164.html


-- 
With warm regards,
Sachin