From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 05/14] cxd2820r_core: fix sparse warnings
Date: Fri, 04 Oct 2013 17:36:47 +0300 [thread overview]
Message-ID: <524ED27F.2010803@iki.fi> (raw)
In-Reply-To: <1380895312-30863-6-git-send-email-hverkuil@xs4all.nl>
On 04.10.2013 17:01, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> drivers/media/dvb-frontends/cxd2820r_core.c:34:32: error: cannot size expression
> drivers/media/dvb-frontends/cxd2820r_core.c:68:32: error: cannot size expression
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
> Cc: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/dvb-frontends/cxd2820r_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c
> index 7ca5c69..d9eeeb1 100644
> --- a/drivers/media/dvb-frontends/cxd2820r_core.c
> +++ b/drivers/media/dvb-frontends/cxd2820r_core.c
> @@ -31,7 +31,7 @@ static int cxd2820r_wr_regs_i2c(struct cxd2820r_priv *priv, u8 i2c, u8 reg,
> {
> .addr = i2c,
> .flags = 0,
> - .len = sizeof(buf),
> + .len = len + 1,
> .buf = buf,
> }
> };
> @@ -65,7 +65,7 @@ static int cxd2820r_rd_regs_i2c(struct cxd2820r_priv *priv, u8 i2c, u8 reg,
> }, {
> .addr = i2c,
> .flags = I2C_M_RD,
> - .len = sizeof(buf),
> + .len = len,
> .buf = buf,
> }
> };
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-10-04 14:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 14:01 [PATCH 00/14] Fixes for sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 01/14] hdpvr: fix " Hans Verkuil
2013-10-04 14:01 ` [PATCH 02/14] pvrusb2: fix sparse warning Hans Verkuil
2013-10-05 3:01 ` Mike Isely
2013-10-04 14:01 ` [PATCH 03/14] timblogiw: fix two sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 04/14] tuner-xs2028.c: fix " Hans Verkuil
2013-10-04 15:34 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 05/14] cxd2820r_core: " Hans Verkuil
2013-10-04 14:36 ` Antti Palosaari [this message]
2013-10-04 15:35 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 06/14] drxd_hard: " Hans Verkuil
2013-10-04 14:44 ` Antti Palosaari
2013-10-04 15:35 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 07/14] drxk_hard: " Hans Verkuil
2013-10-04 14:40 ` Antti Palosaari
2013-10-04 15:35 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 08/14] fmdrv_common: fix sparse warning Hans Verkuil
2013-10-04 14:01 ` [PATCH 09/14] radio-keene: " Hans Verkuil
2013-10-04 14:01 ` [PATCH 10/14] az6027: fix sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 11/14] cx231xx: " Hans Verkuil
2013-10-04 14:01 ` [PATCH 12/14] tlg2300: fix sparse warning Hans Verkuil
2013-10-04 14:01 ` [PATCH 13/14] cx25821: fix sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 14/14] siano: " Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524ED27F.2010803@iki.fi \
--to=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox