From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 06/14] drxd_hard: fix sparse warnings
Date: Fri, 04 Oct 2013 17:44:06 +0300 [thread overview]
Message-ID: <524ED436.6030001@iki.fi> (raw)
In-Reply-To: <1380895312-30863-7-git-send-email-hverkuil@xs4all.nl>
On 04.10.2013 17:01, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> drivers/media/dvb-frontends/drxd_hard.c:1017:70: warning: Using plain integer as NULL pointer
> drivers/media/dvb-frontends/drxd_hard.c:1038:69: warning: Using plain integer as NULL pointer
> drivers/media/dvb-frontends/drxd_hard.c:2836:33: warning: Using plain integer as NULL pointer
> drivers/media/dvb-frontends/drxd_hard.c:2972:30: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
> Cc: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/dvb-frontends/drxd_hard.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/drxd_hard.c b/drivers/media/dvb-frontends/drxd_hard.c
> index cbd7c92..959ae36 100644
> --- a/drivers/media/dvb-frontends/drxd_hard.c
> +++ b/drivers/media/dvb-frontends/drxd_hard.c
> @@ -1014,7 +1014,7 @@ static int HI_CfgCommand(struct drxd_state *state)
> status = Write16(state, HI_RA_RAM_SRV_CMD__A,
> HI_RA_RAM_SRV_CMD_CONFIG, 0);
> else
> - status = HI_Command(state, HI_RA_RAM_SRV_CMD_CONFIG, 0);
> + status = HI_Command(state, HI_RA_RAM_SRV_CMD_CONFIG, NULL);
> mutex_unlock(&state->mutex);
> return status;
> }
> @@ -1035,7 +1035,7 @@ static int HI_ResetCommand(struct drxd_state *state)
> status = Write16(state, HI_RA_RAM_SRV_RST_KEY__A,
> HI_RA_RAM_SRV_RST_KEY_ACT, 0);
> if (status == 0)
> - status = HI_Command(state, HI_RA_RAM_SRV_CMD_RESET, 0);
> + status = HI_Command(state, HI_RA_RAM_SRV_CMD_RESET, NULL);
> mutex_unlock(&state->mutex);
> msleep(1);
> return status;
> @@ -2833,7 +2833,7 @@ static int drxd_init(struct dvb_frontend *fe)
> int err = 0;
>
> /* if (request_firmware(&state->fw, "drxd.fw", state->dev)<0) */
> - return DRXD_init(state, 0, 0);
> + return DRXD_init(state, NULL, 0);
>
> err = DRXD_init(state, state->fw->data, state->fw->size);
> release_firmware(state->fw);
> @@ -2969,7 +2969,7 @@ struct dvb_frontend *drxd_attach(const struct drxd_config *config,
>
> mutex_init(&state->mutex);
>
> - if (Read16(state, 0, 0, 0) < 0)
> + if (Read16(state, 0, NULL, 0) < 0)
> goto error;
>
> state->frontend.ops = drxd_ops;
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-10-04 14:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 14:01 [PATCH 00/14] Fixes for sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 01/14] hdpvr: fix " Hans Verkuil
2013-10-04 14:01 ` [PATCH 02/14] pvrusb2: fix sparse warning Hans Verkuil
2013-10-05 3:01 ` Mike Isely
2013-10-04 14:01 ` [PATCH 03/14] timblogiw: fix two sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 04/14] tuner-xs2028.c: fix " Hans Verkuil
2013-10-04 15:34 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 05/14] cxd2820r_core: " Hans Verkuil
2013-10-04 14:36 ` Antti Palosaari
2013-10-04 15:35 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 06/14] drxd_hard: " Hans Verkuil
2013-10-04 14:44 ` Antti Palosaari [this message]
2013-10-04 15:35 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 07/14] drxk_hard: " Hans Verkuil
2013-10-04 14:40 ` Antti Palosaari
2013-10-04 15:35 ` Michael Krufky
2013-10-04 14:01 ` [PATCH 08/14] fmdrv_common: fix sparse warning Hans Verkuil
2013-10-04 14:01 ` [PATCH 09/14] radio-keene: " Hans Verkuil
2013-10-04 14:01 ` [PATCH 10/14] az6027: fix sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 11/14] cx231xx: " Hans Verkuil
2013-10-04 14:01 ` [PATCH 12/14] tlg2300: fix sparse warning Hans Verkuil
2013-10-04 14:01 ` [PATCH 13/14] cx25821: fix sparse warnings Hans Verkuil
2013-10-04 14:01 ` [PATCH 14/14] siano: " Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524ED436.6030001@iki.fi \
--to=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox