From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:48455 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038Ab3JLLLR (ORCPT ); Sat, 12 Oct 2013 07:11:17 -0400 Message-ID: <52592E51.90709@gmail.com> Date: Sat, 12 Oct 2013 13:11:13 +0200 From: Sylwester Nawrocki MIME-Version: 1.0 To: Hans Verkuil CC: Sylwester Nawrocki , linux-media@vger.kernel.org, kyungmin.park@samsung.com, pawel@osciak.com, javier.martin@vista-silicon.com, m.szyprowski@samsung.com, shaik.ameer@samsung.com, arun.kk@samsung.com, k.debski@samsung.com, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH RFC 5/7] mx2-emmaprp: Use mem-to-mem ioctl helpers References: <1379076986-10446-1-git-send-email-s.nawrocki@samsung.com> <1379076986-10446-6-git-send-email-s.nawrocki@samsung.com> <524948CB.8010807@xs4all.nl> In-Reply-To: <524948CB.8010807@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/30/2013 11:47 AM, Hans Verkuil wrote: > On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: [...] >> @@ -812,6 +753,7 @@ static int emmaprp_open(struct file *file) >> kfree(ctx); >> return ret; >> } >> + /* TODO: Assign fh->m2m_ctx, needs conversion to struct v4l2_fh first */ > > What's the point of adding this patch if it won't work yet? Sorry, I shouldn't have included that commit in this series yet, that's my oversight. And it didn't prove a good way to draw people's attention to this RFC series either. ;) Nevertheless, I have already written the missing patch and will be sending v2 of this series shortly. -- Thanks, Sylwester