From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [GIT PULL FOR v3.13] Various fixes
Date: Tue, 15 Oct 2013 00:59:02 +0200 [thread overview]
Message-ID: <525C7736.4050502@gmail.com> (raw)
In-Reply-To: <20131014092839.6049ee6a@samsung.com>
On 10/14/2013 02:28 PM, Mauro Carvalho Chehab wrote:
>> Sylwester Nawrocki (1):
>> v4l2-ctrls: Correct v4l2_ctrl_get_int_menu() function prototype
>
> This patch is wrong or incomplete, as it calls hundreds of warnings (see below).
> I'll just drop it:
>
> $ make ARCH=i386 CONFIG_DEBUG_SECTION_MISMATCH=y W=1 M=drivers/staging/media
>
> WARNING: Symbol version dump /devel/v4l/patchwork/Module.symvers
> is missing; modules will have no dependencies and modversions.
>
> In file included from include/media/v4l2-subdev.h:28:0,
> from include/media/v4l2-device.h:25,
> from drivers/staging/media/go7007/s2250-board.c:24:
> include/media/v4l2-common.h:89:19: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
> const s64 * const v4l2_ctrl_get_int_menu(u32 id, u32 *len);
Yes, it rightfully does so, since even if the pointer is const, it will
still be modifiable, due to pass-by-value language conventions. Sorry for
wasting your time with that crappy patch, I'll post a new one with the
second 'const' removed.
Regards,
Sylwester
next prev parent reply other threads:[~2013-10-14 22:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 10:37 [GIT PULL FOR v3.13] Various fixes Hans Verkuil
2013-10-14 12:28 ` Mauro Carvalho Chehab
2013-10-14 22:58 ` Sylwester Nawrocki
2013-10-14 22:59 ` Sylwester Nawrocki [this message]
2013-10-14 23:08 ` [PATCH v2] v4l2-ctrls: Correct v4l2_ctrl_get_int_menu() function's return type Sylwester Nawrocki
2013-10-14 12:30 ` [GIT PULL FOR v3.13] Various fixes Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2013-11-11 14:32 Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C7736.4050502@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox