From: Antti Palosaari <crope@iki.fi>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] rtl2830: add parent for I2C adapter
Date: Tue, 29 Oct 2013 23:17:17 +0200 [thread overview]
Message-ID: <527025DD.2060205@iki.fi> (raw)
In-Reply-To: <52658CA7.5080104@iki.fi>
Wolfram,
Phil email address was not valid anymore, so could you Wolfram, as a I2C
subsystem maintainer, look and comment that. The fact is that my driver
has a 3.12 regression and I want to know where it is coming from to make
decision what to do!
regards
Antti
On 21.10.2013 23:20, Antti Palosaari wrote:
> Hello Phil and Wolfram,
>
> I found one of my drivers was crashing when DTV USB stick was plugged.
> Patch in that mail patch fixes the problem.
>
> I quickly looked possible I2C patches causing the problem and saw that
> one as most suspicions:
>
> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>
> My config has no CONFIG_I2C_MUX set currently, but I am not sure how it
> has been earlier.
>
> Any idea?
>
> regards
> Antti
>
>
> On 21.10.2013 23:12, Antti Palosaari wrote:
>> i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
>> IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
>>
>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>> ---
>> drivers/media/dvb-frontends/rtl2830.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/dvb-frontends/rtl2830.c
>> b/drivers/media/dvb-frontends/rtl2830.c
>> index 362d26d..68ee70b 100644
>> --- a/drivers/media/dvb-frontends/rtl2830.c
>> +++ b/drivers/media/dvb-frontends/rtl2830.c
>> @@ -700,6 +700,7 @@ struct dvb_frontend *rtl2830_attach(const struct
>> rtl2830_config *cfg,
>> sizeof(priv->tuner_i2c_adapter.name));
>> priv->tuner_i2c_adapter.algo = &rtl2830_tuner_i2c_algo;
>> priv->tuner_i2c_adapter.algo_data = NULL;
>> + priv->tuner_i2c_adapter.dev.parent = &i2c->dev;
>> i2c_set_adapdata(&priv->tuner_i2c_adapter, priv);
>> if (i2c_add_adapter(&priv->tuner_i2c_adapter) < 0) {
>> dev_err(&i2c->dev,
>>
>
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-10-29 21:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 20:12 [PATCH] rtl2830: add parent for I2C adapter Antti Palosaari
2013-10-21 20:20 ` Antti Palosaari
2013-10-29 21:17 ` Antti Palosaari [this message]
2013-10-30 15:16 ` Wolfram Sang
2013-10-30 15:35 ` Antti Palosaari
2013-10-30 15:36 ` Antti Palosaari
2013-10-30 15:45 ` Wolfram Sang
2013-10-30 15:51 ` Antti Palosaari
2013-10-30 16:02 ` Wolfram Sang
2013-10-30 16:29 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527025DD.2060205@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).