From: Antti Palosaari <crope@iki.fi>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] rtl2830: add parent for I2C adapter
Date: Wed, 30 Oct 2013 17:35:24 +0200 [thread overview]
Message-ID: <5271273C.4090604@iki.fi> (raw)
In-Reply-To: <20131030151620.GB3663@katana>
On 30.10.2013 17:16, Wolfram Sang wrote:
> Hi,
>
> sorry for the delay. The Kernel Summit made a pretty busy time out of
> the last weeks...
>
>> I found one of my drivers was crashing when DTV USB stick was
>> plugged. Patch in that mail patch fixes the problem.
>
> Well, if you have a parent, it should be set. This is always a good
> idea. Can't really tell why not having it causes the BUG, though.
>
>> I quickly looked possible I2C patches causing the problem and saw
>> that one as most suspicions:
>>
>> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
>> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>
> Did you try reverting it? I am not sure this is the one.
Nope, not to mentio bisect. I have done bisect few times and I am not
going to waste whole day of compiling and booting new kernels.
Crash disappeared whit that little patch. I did also some DVB USB core
changes for 3.12, but I cannot see it could be root of cause that crash.
>>> i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
>>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
>>> IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
>
> Can we have the full BUG output?
See attachement.
Anyway, I am going to ask Mauro to merge that I2C parent patch and maybe
try to sent it stable too as it is likely a bit too late for 3.12 RC.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-10-30 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 20:12 [PATCH] rtl2830: add parent for I2C adapter Antti Palosaari
2013-10-21 20:20 ` Antti Palosaari
2013-10-29 21:17 ` Antti Palosaari
2013-10-30 15:16 ` Wolfram Sang
2013-10-30 15:35 ` Antti Palosaari [this message]
2013-10-30 15:36 ` Antti Palosaari
2013-10-30 15:45 ` Wolfram Sang
2013-10-30 15:51 ` Antti Palosaari
2013-10-30 16:02 ` Wolfram Sang
2013-10-30 16:29 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271273C.4090604@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).