From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:48063 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962Ab3KBRFY (ORCPT ); Sat, 2 Nov 2013 13:05:24 -0400 Message-ID: <527530D0.7060409@iki.fi> Date: Sat, 02 Nov 2013 19:05:20 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCHv2 26/29] af9015: Don't use dynamic static allocation References: <1383399097-11615-1-git-send-email-m.chehab@samsung.com> <1383399097-11615-27-git-send-email-m.chehab@samsung.com> In-Reply-To: <1383399097-11615-27-git-send-email-m.chehab@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: ACK. IIRC I did macro optimization here and that used way gives few bytes smaller footprint =) Antti On 02.11.2013 15:31, Mauro Carvalho Chehab wrote: > Dynamic static allocation is evil, as Kernel stack is too low, and > ompilation complains about it on some archs: > > drivers/media/usb/dvb-usb-v2/af9015.c:433:1: warning: 'af9015_eeprom_hash' uses dynamic stack allocation [enabled by default] > > In this specific case, it is a gcc bug, as the size is a const, but > it is easy to just change it from const to a #define, getting rid of > the gcc warning. > > Signed-off-by: Mauro Carvalho Chehab > Cc: Antti Palosaari Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari > --- > drivers/media/usb/dvb-usb-v2/af9015.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-v2/af9015.c > index d556042cf312..da47d2392f2a 100644 > --- a/drivers/media/usb/dvb-usb-v2/af9015.c > +++ b/drivers/media/usb/dvb-usb-v2/af9015.c > @@ -397,12 +397,13 @@ error: > return ret; > } > > +#define AF9015_EEPROM_SIZE 256 > + > /* hash (and dump) eeprom */ > static int af9015_eeprom_hash(struct dvb_usb_device *d) > { > struct af9015_state *state = d_to_priv(d); > int ret, i; > - static const unsigned int AF9015_EEPROM_SIZE = 256; > u8 buf[AF9015_EEPROM_SIZE]; > struct req_t req = {READ_I2C, AF9015_I2C_EEPROM, 0, 0, 1, 1, NULL}; > > -- http://palosaari.fi/