From: Antti Palosaari <crope@iki.fi>
To: CrazyCat <crazycat69@narod.ru>, linux-media@vger.kernel.org
Subject: Re: [PATCH] cxd2820r_c: Fix if_ctl calculation
Date: Sun, 03 Nov 2013 19:41:34 +0200 [thread overview]
Message-ID: <52768ACE.2040108@iki.fi> (raw)
In-Reply-To: <5276856E.3000209@iki.fi>
On 03.11.2013 19:18, Antti Palosaari wrote:
> CrazyCat,
>
> Could you fix your mailer? Or tell me the command I can import that
> patch to my local git tree for testing?
>
> git send-email is at least know to break patches.
*not* to break patches!
>
>
> I will manually applying that patch and testing, but..
>
>
>
> error: drivers/media/dvb-frontends/cxd2820r_c.c: patch does not apply
I tested it, by manually copy & pasting that single line. I didn't
noticed any change to existing behavior, but I have no reason to suspect
patch is wrong.
I am not going to apply that via my tree as patch fails.
It is up to subsystem maintainers to pick it up.
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Tested-by: Antti Palosaari <crope@iki.fi>
regards
Antti
>
> On 02.11.2013 23:04, CrazyCat wrote:
>> Fix tune for DVB-C.
>>
>> Signed-off-by: Evgeny Plehov <EvgenyPlehov@ukr.net>
>> diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c
>> b/drivers/media/dvb-frontends/cxd2820r_c.c
>> index 125a440..5c6ab49 100644
>> --- a/drivers/media/dvb-frontends/cxd2820r_c.c
>> +++ b/drivers/media/dvb-frontends/cxd2820r_c.c
>> @@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe)
>>
>> num = if_freq / 1000; /* Hz => kHz */
>> num *= 0x4000;
>> - if_ctl = cxd2820r_div_u64_round_closest(num, 41000);
>> + if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000);
>> buf[0] = (if_ctl >> 8) & 0x3f;
>> buf[1] = (if_ctl >> 0) & 0xff;
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-11-03 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 21:04 [PATCH] cxd2820r_c: Fix if_ctl calculation CrazyCat
2013-11-03 17:18 ` Antti Palosaari
2013-11-03 17:41 ` Antti Palosaari [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-01 20:06 CrazyCat
2013-11-01 20:11 ` Antti Palosaari
2013-11-01 19:27 CrazyCat
2013-11-01 20:01 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52768ACE.2040108@iki.fi \
--to=crope@iki.fi \
--cc=crazycat69@narod.ru \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).