From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Sergio Aguirre <sergio.a.aguirre@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH v2 00/18] OMAP4 ISS driver
Date: Mon, 04 Nov 2013 11:59:33 +0100 [thread overview]
Message-ID: <52777E15.9050303@xs4all.nl> (raw)
In-Reply-To: <52776BD3.60309@xs4all.nl>
On 11/04/2013 10:41 AM, Hans Verkuil wrote:
> Hi Laurent,
>
> For this whole patch series:
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
And also for patches 19-22 :-)
Thanks!
Hans
>
> I strongly recommend that you add another patch adding the s_input function.
> It's trivial to do and it will make v4l2-compliance happy :-)
>
> Fixing the issue with iss_video_try_format() and a missing get_fmt op is nice-to-have,
> but can be done later.
>
> Regards,
>
> Hans
>
> On 11/04/2013 01:06 AM, Laurent Pinchart wrote:
>> Hello,
>>
>> This is the second version of the OMAP4 ISS driver patches for inclusion in the
>> mainline kernel. I've addressed most of the comments received on the first
>> version (some of them are still being discussed) in additional patches, except
>> for the file path updates in the documentation that have been squashed with
>> patch 01/18.
>>
>> The OMAP4 ISS driver has lived out of tree for more than two years now. This
>> situation is both sad and resource-wasting, as the driver has been used (and
>> thus) hacked since then with nowhere to send patches to. Time has come to fix
>> the problem.
>>
>> As the code is mostly, but not quite ready for prime time, I'd like to request
>> its addition to drivers/staging/. I've added a (pretty small) TODO file and I
>> commit to cleaning up the code and get it to drivers/media/ where it belongs.
>>
>> I've split the driver in six patches to avoid getting caught in vger's size
>> and to make review slightly easier. Sergio Aguirre is the driver author (huge
>> thanks for that!), I've thus kept his authorship on patches 1/6 to 5/6. Beside
>> minimal changes to make the code compile on v3.12 and updates the file paths in
>> the documentation I've kept Sergio's code unmodified.
>>
>> I don't have much else to add here, let's get this beast to mainline and allow
>> other developers to use the driver and contribute patches. Given that v3.12 has
>> just been released I'm fine with pushing this series back to v3.13.
>>
>> Laurent Pinchart (13):
>> v4l: omap4iss: Add support for OMAP4 camera interface - Build system
>> v4l: omap4iss: Don't use v4l2_g_ext_ctrls() internally
>> v4l: omap4iss: Move common code out of switch...case
>> v4l: omap4iss: Report device caps in response to VIDIOC_QUERYCAP
>> v4l: omap4iss: Remove iss_video streaming field
>> v4l: omap4iss: Set the vb2 timestamp type
>> v4l: omap4iss: Remove duplicate video_is_registered() check
>> v4l: omap4iss: Remove unneeded status variable
>> v4l: omap4iss: Replace udelay/msleep with usleep_range
>> v4l: omap4iss: Make omap4iss_isp_subclk_(en|dis)able() functions void
>> v4l: omap4iss: Make loop counters unsigned where appropriate
>> v4l: omap4iss: Don't initialize fields to 0 manually
>> v4l: omap4iss: Simplify error paths
>>
>> Sergio Aguirre (5):
>> v4l: omap4iss: Add support for OMAP4 camera interface - Core
>> v4l: omap4iss: Add support for OMAP4 camera interface - Video devices
>> v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers
>> v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF)
>> v4l: omap4iss: Add support for OMAP4 camera interface - Resizer
>>
>> Documentation/video4linux/omap4_camera.txt | 60 ++
>> drivers/staging/media/Kconfig | 2 +
>> drivers/staging/media/Makefile | 1 +
>> drivers/staging/media/omap4iss/Kconfig | 12 +
>> drivers/staging/media/omap4iss/Makefile | 6 +
>> drivers/staging/media/omap4iss/TODO | 4 +
>> drivers/staging/media/omap4iss/iss.c | 1462 ++++++++++++++++++++++++++
>> drivers/staging/media/omap4iss/iss.h | 153 +++
>> drivers/staging/media/omap4iss/iss_csi2.c | 1368 ++++++++++++++++++++++++
>> drivers/staging/media/omap4iss/iss_csi2.h | 156 +++
>> drivers/staging/media/omap4iss/iss_csiphy.c | 278 +++++
>> drivers/staging/media/omap4iss/iss_csiphy.h | 51 +
>> drivers/staging/media/omap4iss/iss_ipipe.c | 581 ++++++++++
>> drivers/staging/media/omap4iss/iss_ipipe.h | 67 ++
>> drivers/staging/media/omap4iss/iss_ipipeif.c | 847 +++++++++++++++
>> drivers/staging/media/omap4iss/iss_ipipeif.h | 92 ++
>> drivers/staging/media/omap4iss/iss_regs.h | 883 ++++++++++++++++
>> drivers/staging/media/omap4iss/iss_resizer.c | 905 ++++++++++++++++
>> drivers/staging/media/omap4iss/iss_resizer.h | 75 ++
>> drivers/staging/media/omap4iss/iss_video.c | 1124 ++++++++++++++++++++
>> drivers/staging/media/omap4iss/iss_video.h | 198 ++++
>> include/media/omap4iss.h | 65 ++
>> 22 files changed, 8390 insertions(+)
>> create mode 100644 Documentation/video4linux/omap4_camera.txt
>> create mode 100644 drivers/staging/media/omap4iss/Kconfig
>> create mode 100644 drivers/staging/media/omap4iss/Makefile
>> create mode 100644 drivers/staging/media/omap4iss/TODO
>> create mode 100644 drivers/staging/media/omap4iss/iss.c
>> create mode 100644 drivers/staging/media/omap4iss/iss.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_csi2.c
>> create mode 100644 drivers/staging/media/omap4iss/iss_csi2.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.c
>> create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.c
>> create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.c
>> create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_regs.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_resizer.c
>> create mode 100644 drivers/staging/media/omap4iss/iss_resizer.h
>> create mode 100644 drivers/staging/media/omap4iss/iss_video.c
>> create mode 100644 drivers/staging/media/omap4iss/iss_video.h
>> create mode 100644 include/media/omap4iss.h
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-11-04 10:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 0:06 [PATCH v2 00/18] OMAP4 ISS driver Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 01/18] v4l: omap4iss: Add support for OMAP4 camera interface - Core Laurent Pinchart
2013-12-03 17:02 ` Mauro Carvalho Chehab
2013-12-03 17:14 ` Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 02/18] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 03/18] v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 04/18] v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF) Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 05/18] v4l: omap4iss: Add support for OMAP4 camera interface - Resizer Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 06/18] v4l: omap4iss: Add support for OMAP4 camera interface - Build system Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 07/18] v4l: omap4iss: Don't use v4l2_g_ext_ctrls() internally Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 08/18] v4l: omap4iss: Move common code out of switch...case Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 09/18] v4l: omap4iss: Report device caps in response to VIDIOC_QUERYCAP Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 10/18] v4l: omap4iss: Remove iss_video streaming field Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 11/18] v4l: omap4iss: Set the vb2 timestamp type Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 12/18] v4l: omap4iss: Remove duplicate video_is_registered() check Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 13/18] v4l: omap4iss: Remove unneeded status variable Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 14/18] v4l: omap4iss: Replace udelay/msleep with usleep_range Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 15/18] v4l: omap4iss: Make omap4iss_isp_subclk_(en|dis)able() functions void Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 16/18] v4l: omap4iss: Make loop counters unsigned where appropriate Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 17/18] v4l: omap4iss: Don't initialize fields to 0 manually Laurent Pinchart
2013-11-04 0:06 ` [PATCH v2 18/18] v4l: omap4iss: Simplify error paths Laurent Pinchart
2013-11-04 9:41 ` [PATCH v2 00/18] OMAP4 ISS driver Hans Verkuil
2013-11-04 10:59 ` Hans Verkuil [this message]
2013-11-04 10:04 ` [PATCH v2 19/18] v4l: omap4iss: Don't check for missing get_fmt op on remote subdev Laurent Pinchart
2013-11-04 10:04 ` [PATCH v2 20/18] v4l: omap4iss: Translate -ENOIOCTLCMD to -ENOTTY Laurent Pinchart
2013-11-04 10:04 ` [PATCH v2 21/18] v4l: omap4iss: Move code out of mutex-protected section Laurent Pinchart
2013-11-04 10:04 ` [PATCH v2 22/18] v4l: omap4iss: Implement VIDIOC_S_INPUT Laurent Pinchart
2013-11-04 10:06 ` [PATCH v2 00/18] OMAP4 ISS driver Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52777E15.9050303@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sergio.a.aguirre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox