public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* ivtv 1.4.2/1.4.3 broken in recent kernels?
@ 2013-09-17 20:49 Rajil Saraswat
  2013-09-30 11:33 ` Hans Verkuil
  2013-10-10  2:20 ` Andy Walls
  0 siblings, 2 replies; 18+ messages in thread
From: Rajil Saraswat @ 2013-09-17 20:49 UTC (permalink / raw)
  To: linux-media

Hi,

 I have a couple of PVR-500's which have additional tuners connected
to them (using daughter cards). The audio is not usable on either
1.4.2 or 1.4.3 ivtv drivers. The issue is described at
http://ivtvdriver.org/pipermail/ivtv-users/2013-September/010462.html

Is there anything i can do to make kernel 3.10.7 (ivtv 1.4.3) play
nice with my card?


Thanks

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-09-17 20:49 ivtv 1.4.2/1.4.3 broken in recent kernels? Rajil Saraswat
@ 2013-09-30 11:33 ` Hans Verkuil
  2013-10-05 13:10   ` Rajil Saraswat
  2013-10-10  2:20 ` Andy Walls
  1 sibling, 1 reply; 18+ messages in thread
From: Hans Verkuil @ 2013-09-30 11:33 UTC (permalink / raw)
  To: Rajil Saraswat; +Cc: linux-media, Andy Walls

On 09/17/2013 10:49 PM, Rajil Saraswat wrote:
> Hi,
> 
>  I have a couple of PVR-500's which have additional tuners connected
> to them (using daughter cards). The audio is not usable on either
> 1.4.2 or 1.4.3 ivtv drivers. The issue is described at
> http://ivtvdriver.org/pipermail/ivtv-users/2013-September/010462.html
> 
> Is there anything i can do to make kernel 3.10.7 (ivtv 1.4.3) play
> nice with my card?

Andy, is this something you can look at?

Regards,

	Hans

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-09-30 11:33 ` Hans Verkuil
@ 2013-10-05 13:10   ` Rajil Saraswat
       [not found]     ` <CAFoaQoDS6LUKNQ7dHF1s1Ms_YuS98mZzrhXRjLLarHHUxsSxMQ@mail.gmail.com>
  0 siblings, 1 reply; 18+ messages in thread
From: Rajil Saraswat @ 2013-10-05 13:10 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media, Andy Walls

Have been using with ivtv-1.4.0 with kernel 2.6.35 (gentoo) for the
past 1 week and daughter card (audio/video)  is working well.

Also tried Suse-12.3 with kernel 3.7.10, and daughter card gives unusable audio.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
       [not found]     ` <CAFoaQoDS6LUKNQ7dHF1s1Ms_YuS98mZzrhXRjLLarHHUxsSxMQ@mail.gmail.com>
@ 2013-10-07 15:01       ` Rajil Saraswat
  0 siblings, 0 replies; 18+ messages in thread
From: Rajil Saraswat @ 2013-10-07 15:01 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: Andy Walls, linux-media

> Have been using with ivtv-1.4.0 with kernel 2.6.35 (gentoo) for the
> past 1 week and daughter card (audio/video)  is working well.
>
> Also tried Suse-12.3 with kernel 3.7.10, and daughter card gives unusable
> audio.

1.4.0 above was a typo, should have been 1.4.1.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-09-17 20:49 ivtv 1.4.2/1.4.3 broken in recent kernels? Rajil Saraswat
  2013-09-30 11:33 ` Hans Verkuil
@ 2013-10-10  2:20 ` Andy Walls
  2013-10-10 21:00   ` Rajil Saraswat
  1 sibling, 1 reply; 18+ messages in thread
From: Andy Walls @ 2013-10-10  2:20 UTC (permalink / raw)
  To: Rajil Saraswat; +Cc: linux-media, Hans Verkuil

On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote:
> Hi,
> 
>  I have a couple of PVR-500's which have additional tuners connected
> to them (using daughter cards).

The PVR-500's don't have daughter cards with additional tuners AFAIK. 

There is this however:
http://www.hauppauge.com/site/webstore2/webstore_avcable-pci.asp

Make sure you have any jumpers set properly and the cable connectors
seated properly.

Also make sure the cable is routed aways from any electrically noisy
cards and high speed data busses: disk controller cards, graphics cards,
etc.  

>  The audio is not usable on either
> 1.4.2 or 1.4.3 ivtv drivers. The issue is described at
> http://ivtvdriver.org/pipermail/ivtv-users/2013-September/010462.html

With your previous working kernel and with the non-working kernel, what
is the output of

$ v4l2-ctl -d /dev/videoX --log-status

after you have set up the inputs properly and have a known good signal
going into the input in question?

I'm speculating this is a problem with the cx25840 driver or the wm8775
driver, since they change more often than the ivtv driver.

BTW, I have very little time to fix things nowadays.

Also my development machine with PCI slots is tied up running simulation
experiments for 4 more weeks.  I can't test any fixes until those
simulations are done.

> Is there anything i can do to make kernel 3.10.7 (ivtv 1.4.3) play
> nice with my card?

1. Differential analysis of the v4l2-ctl --log-status output

2. Differential analysis of the kernel source code for the ivtv, cx2580,
and wm8775 drivers.

3. git bisection of the kernel starting from known good and bad kernel
versions, compile kernel, test, repeat.
http://git-scm.com/book/en/Git-Tools-Debugging-with-Git#Binary-Search
http://lwn.net/Articles/317154/

That's what I'd have to do, but it takes time and a setup that is able
to reporduce the problem reliably.

The git bisect is guaranteed to terminate on the problem change, if it
is a software change that caused the problem.

Although it doesn't sound like a hardware problem so far:

If it is a hardware problem induced by a change in hardware, or the way
the hardware is being driven, then verify your cables and any jumpers
and take steps to reduce EMI on the audio lines (move the cables away
from potential noise sources).  Also, if you suspect hardware, remove
*all* the PCI cards, blow the dust out of the PCI slots and reseat them.

Regards,
Andy


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-10  2:20 ` Andy Walls
@ 2013-10-10 21:00   ` Rajil Saraswat
  2013-10-12 23:23     ` Andy Walls
  0 siblings, 1 reply; 18+ messages in thread
From: Rajil Saraswat @ 2013-10-10 21:00 UTC (permalink / raw)
  To: Andy Walls; +Cc: linux-media, Hans Verkuil

On 10 October 2013 03:20, Andy Walls <awalls@md.metrocast.net> wrote:
> On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote:
>> Hi,
>>
>>  I have a couple of PVR-500's which have additional tuners connected
>> to them (using daughter cards).
>
> The PVR-500's don't have daughter cards with additional tuners AFAIK.
>
> There is this however:
> http://www.hauppauge.com/site/webstore2/webstore_avcable-pci.asp
>
> Make sure you have any jumpers set properly and the cable connectors
> seated properly.
>
> Also make sure the cable is routed aways from any electrically noisy
> cards and high speed data busses: disk controller cards, graphics cards,
> etc.
>
>>  The audio is not usable on either
>> 1.4.2 or 1.4.3 ivtv drivers. The issue is described at
>> http://ivtvdriver.org/pipermail/ivtv-users/2013-September/010462.html
>
> With your previous working kernel and with the non-working kernel, what
> is the output of
>
> $ v4l2-ctl -d /dev/videoX --log-status
>
> after you have set up the inputs properly and have a known good signal
> going into the input in question?
>
> I'm speculating this is a problem with the cx25840 driver or the wm8775
> driver, since they change more often than the ivtv driver.

Yes, thats right it is a set of extra inputs and not a separate tuner
card. I played a video stream fro both kernels. Here are the logs

Working kernel 2.6.35
 v4l2-ctl -d /dev/video1 --log-status

Status Log:

   [50885.487963] ivtv1: =================  START STATUS CARD #1
=================
   [50885.487967] ivtv1: Version: 1.4.1 Card: WinTV PVR 500 (unit #2)
   [50885.541679] tveeprom 2-0050: Hauppauge model 23559, rev D591,
serial# 8228753
   [50885.541681] tveeprom 2-0050: tuner model is Philips FQ1216AME
MK4 (idx 91, type 56)
   [50885.541684] tveeprom 2-0050: TV standards PAL(B/G) PAL(I)
SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
   [50885.541686] tveeprom 2-0050: second tuner model is Philips
TEA5768HL FM Radio (idx 101, type 62)
   [50885.541688] tveeprom 2-0050: audio processor is CX25843 (idx 37)
   [50885.541690] tveeprom 2-0050: decoder processor is CX25843 (idx 30)
   [50885.541692] tveeprom 2-0050: has radio
   [50885.541698] ivtv1: GPIO status: DIR=0xdf01 OUT=0x26f3 IN=0x17e7
   [50885.545429] cx25840 2-0044: Video signal:              present
   [50885.545431] cx25840 2-0044: Detected format:           PAL-BDGHI
   [50885.545433] cx25840 2-0044: Specified standard:        PAL-BDGHI
   [50885.545435] cx25840 2-0044: Specified video input:     Composite 4
   [50885.545437] cx25840 2-0044: Specified audioclock freq: 48000 Hz
   [50885.553051] cx25840 2-0044: Detected audio mode:       forced mode
   [50885.553053] cx25840 2-0044: Detected audio standard:   no
detected audio standard
   [50885.553055] cx25840 2-0044: Audio muted:               no
   [50885.553057] cx25840 2-0044: Audio microcontroller:     stopped
   [50885.553059] cx25840 2-0044: Configured audio standard: automatic detection
   [50885.553061] cx25840 2-0044: Configured audio system:   automatic
standard and mode detection
   [50885.553063] cx25840 2-0044: Specified audio input:     External
   [50885.553064] cx25840 2-0044: Preferred audio mode:      stereo
   [50885.553066] cx25840 2-0044: Selected 65 MHz format:    system DK
   [50885.553068] cx25840 2-0044: Selected 45 MHz format:    chroma
   [50885.553070] tda9887 2-0043: Data bytes: b=0x94 c=0x6e e=0x49
   [50885.553073] tuner 2-0061: Tuner mode:      analog TV
   [50885.553075] tuner 2-0061: Frequency:       400.00 MHz
   [50885.553077] tuner 2-0061: Standard:        0x00000007
   [50885.553079] wm8775 2-001b: Input: 4
   [50885.553081] ivtv1: Video Input:  Composite 2
   [50885.553082] ivtv1: Audio Input:  Line In 2
   [50885.553084] ivtv1: Tuner:  TV
   [50885.553086] ivtv1: Stream: MPEG-2 Program Stream
   [50885.553088] ivtv1: VBI Format: No VBI
   [50885.553089] ivtv1: Video:  720x576, 25 fps
   [50885.553092] ivtv1: Video:  MPEG-2, 4x3, Variable Bitrate,
6000000, Peak 8000000
   [50885.553094] ivtv1: Video:  GOP Size 12, 2 B-Frames, GOP Closure
   [50885.553097] ivtv1: Audio:  48 kHz, MPEG-1/2 Layer II, 224 kbps,
Stereo, No Emphasis, No CRC
   [50885.553100] ivtv1: Spatial Filter:  Manual, Luma 1D Horizontal,
Chroma 1D Horizontal, 0
   [50885.553103] ivtv1: Temporal Filter: Manual, 8
   [50885.553105] ivtv1: Median Filter:   Off, Luma [0, 255], Chroma [0, 255]
   [50885.553106] ivtv1: Status flags:    0x00200000
   [50885.553109] ivtv1: Stream encoder MPG: status 0x0118, 15% of
16384 KiB (512 buffers) in use
   [50885.553112] ivtv1: Stream encoder YUV: status 0x0000, 0% of
20480 KiB (640 buffers) in use
   [50885.553114] ivtv1: Stream encoder VBI: status 0x0000, 0% of 1049
KiB (41 buffers) in use
   [50885.553117] ivtv1: Stream encoder PCM: status 0x0000, 0% of 643
KiB (143 buffers) in use
   [50885.553119] ivtv1: Read MPG/VBI: 56262656/0 bytes
   [50885.553121] ivtv1: ==================  END STATUS CARD #1
==================

For the non-working kernel 2.6.37

   [  212.730996] ivtv1: =================  START STATUS  =================
   [  212.731001] ivtv1: Version: 1.4.3 Card: WinTV PVR 500 (unit #2)
   [  212.784536] tveeprom 2-0050: Hauppauge model 23559, rev D591,
serial# 8228753
   [  212.784539] tveeprom 2-0050: tuner model is Philips FQ1216AME
MK4 (idx 91, type 56)
   [  212.784541] tveeprom 2-0050: TV standards PAL(B/G) PAL(I)
SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
   [  212.784542] tveeprom 2-0050: second tuner model is Philips
TEA5768HL FM Radio (idx 101, type 62)
   [  212.784544] tveeprom 2-0050: audio processor is CX25843 (idx 37)
   [  212.784545] tveeprom 2-0050: decoder processor is CX25843 (idx 30)
   [  212.784546] tveeprom 2-0050: has radio
   [  212.784551] ivtv1: GPIO status: DIR=0xdf01 OUT=0x26f3 IN=0x17e7
   [  212.784588] ivtv1-gpio: Mute: false
   [  212.787820] cx25840 2-0044: Video signal:              present
   [  212.787822] cx25840 2-0044: Detected format:           PAL-BDGHI
   [  212.787823] cx25840 2-0044: Specified standard:        PAL-BDGHI
   [  212.787824] cx25840 2-0044: Specified video input:     Composite 4
   [  212.787825] cx25840 2-0044: Specified audioclock freq: 48000 Hz
   [  212.795328] cx25840 2-0044: Detected audio mode:       forced mode
   [  212.795329] cx25840 2-0044: Detected audio standard:   no
detected audio standard
   [  212.795330] cx25840 2-0044: Audio microcontroller:     stopped
   [  212.795332] cx25840 2-0044: Configured audio standard: automatic detection
   [  212.795333] cx25840 2-0044: Configured audio system:   automatic
standard and mode detection
   [  212.795334] cx25840 2-0044: Specified audio input:     External
   [  212.795335] cx25840 2-0044: Preferred audio mode:      stereo
   [  212.795336] cx25840 2-0044: Selected 65 MHz format:    system DK
   [  212.795337] cx25840 2-0044: Selected 45 MHz format:    chroma
   [  212.807207] cx25840 2-0044: IR Receiver:
   [  212.807208] cx25840 2-0044:       Enabled:                           no
   [  212.807209] cx25840 2-0044:       Demodulation from a carrier:
    disabled
   [  212.807210] cx25840 2-0044:       FIFO:
    disabled
   [  212.807211] cx25840 2-0044:       Pulse timers' start/stop
trigger:  disabled
   [  212.807212] cx25840 2-0044:       FIFO data on pulse timer
overflow: overflow marker
   [  212.807212] cx25840 2-0044:       FIFO data on pulse timer
overflow: overflow marker
   [  212.807213] cx25840 2-0044:       FIFO interrupt watermark:
    half full or greater
   [  212.807214] cx25840 2-0044:       Loopback mode:
    normal receive
   [  212.807215] cx25840 2-0044:       Max measurable pulse width:
    318144512 us, 318144512000 ns
   [  212.807216] cx25840 2-0044:       Low pass filter:
    disabled
   [  212.807217] cx25840 2-0044:       Pulse width timer timed-out:       no
   [  212.807218] cx25840 2-0044:       Pulse width timer time-out
intr:   enabled
   [  212.807219] cx25840 2-0044:       FIFO overrun:                      no
   [  212.807220] cx25840 2-0044:       FIFO overrun interrupt:
    enabled
   [  212.807221] cx25840 2-0044:       Busy:                              no
   [  212.807222] cx25840 2-0044:       FIFO service requested:            no
   [  212.807223] cx25840 2-0044:       FIFO service request
interrupt:    enabled
   [  212.807223] cx25840 2-0044: IR Transmitter:
   [  212.807224] cx25840 2-0044:       Enabled:                           no
   [  212.807225] cx25840 2-0044:       Modulation onto a carrier:
    disabled
   [  212.807226] cx25840 2-0044:       FIFO:
    disabled
   [  212.807227] cx25840 2-0044:       FIFO interrupt watermark:
    half full or less
   [  212.807228] cx25840 2-0044:       Carrier polarity:
    space:noburst mark:burst
   [  212.807229] cx25840 2-0044:       Max pulse width:
    318144512 us, 318144512000 ns
   [  212.807230] cx25840 2-0044:       Busy:                              no
   [  212.807231] cx25840 2-0044:       FIFO service requested:            yes
   [  212.807232] cx25840 2-0044:       FIFO service request
interrupt:    enabled
   [  212.807233] cx25840 2-0044: Brightness: 128
   [  212.807234] cx25840 2-0044: Contrast: 63
   [  212.807235] cx25840 2-0044: Saturation: 63
   [  212.807237] cx25840 2-0044: Hue: 0
   [  212.807238] cx25840 2-0044: Volume: 60928
   [  212.807239] cx25840 2-0044: Mute: false
   [  212.807240] cx25840 2-0044: Balance: 32768
   [  212.807241] cx25840 2-0044: Bass: 32768
   [  212.807242] cx25840 2-0044: Treble: 32768
   [  212.807244] tda9887 2-0043: Data bytes: b=0x94 c=0x6e e=0x49
   [  212.807246] tuner 2-0061: Tuner mode:      analog TV
   [  212.807247] tuner 2-0061: Frequency:       400.00 MHz
   [  212.807248] tuner 2-0061: Standard:        0x00000007
   [  212.807249] wm8775 2-001b: Input: 4
   [  212.807250] wm8775 2-001b: Mute: false
   [  212.807251] wm8775 2-001b: Volume: 52992
   [  212.807253] wm8775 2-001b: Balance: 32768
   [  212.807254] wm8775 2-001b: Loudness: true
   [  212.807256] ivtv1: Video Input:  Composite 2
   [  212.807256] ivtv1: Audio Input:  Line In 2
   [  212.807257] ivtv1: Tuner:  TV
   [  212.807258] ivtv1: Stream Type: MPEG-2 Program Stream grabbed
   [  212.807260] ivtv1: Stream VBI Format: No VBI grabbed
   [  212.807261] ivtv1: Audio Sampling Frequency: 48 kHz grabbed
   [  212.807263] ivtv1: Audio Encoding: MPEG-1/2 Layer II grabbed
   [  212.807264] ivtv1: Audio Layer II Bitrate: 224 kbps grabbed
   [  212.807265] ivtv1: Audio Stereo Mode: Stereo
   [  212.807266] ivtv1: Audio Stereo Mode Extension: Bound 4 inactive
   [  212.807268] ivtv1: Audio Emphasis: No Emphasis
   [  212.807269] ivtv1: Audio CRC: No CRC
   [  212.807270] ivtv1: Audio Mute: false
   [  212.807271] ivtv1: Video Encoding: MPEG-2
   [  212.807272] ivtv1: Video Aspect: 4x3
   [  212.807273] ivtv1: Video B Frames: 2
   [  212.807274] ivtv1: Video GOP Size: 15
   [  212.807276] ivtv1: Video GOP Closure: true
   [  212.807277] ivtv1: Video Bitrate Mode: Variable Bitrate grabbed
   [  212.807278] ivtv1: Video Bitrate: 6000000 grabbed
   [  212.807279] ivtv1: Video Peak Bitrate: 8000000 grabbed
   [  212.807281] ivtv1: Video Temporal Decimation: 0
   [  212.807282] ivtv1: Video Mute: false
   [  212.807283] ivtv1: Video Mute YUV: 32896
   [  212.807284] ivtv1: Spatial Filter Mode: Manual
   [  212.807285] ivtv1: Spatial Filter: 0
   [  212.807286] ivtv1: Spatial Luma Filter Type: 1D Horizontal
   [  212.807287] ivtv1: Spatial Chroma Filter Type: 1D Horizontal
   [  212.807288] ivtv1: Temporal Filter Mode: Manual
   [  212.807289] ivtv1: Temporal Filter: 8
   [  212.807290] ivtv1: Median Filter Type: Off
   [  212.807291] ivtv1: Median Luma Filter Minimum: 0 inactive
   [  212.807293] ivtv1: Median Luma Filter Maximum: 255 inactive
   [  212.807294] ivtv1: Median Chroma Filter Minimum: 0 inactive
   [  212.807295] ivtv1: Median Chroma Filter Maximum: 255 inactive
   [  212.807297] ivtv1: Insert Navigation Packets: false
   [  212.807298] ivtv1: Status flags:    0x00200000
   [  212.807300] ivtv1: Stream encoder MPG: status 0x0118, 18% of
16384 KiB (512 buffers) in use
   [  212.807301] ivtv1: Stream encoder YUV: status 0x0000, 0% of
20480 KiB (640 buffers) in use
   [  212.807303] ivtv1: Stream encoder VBI: status 0x0000, 0% of 1049
KiB (41 buffers) in use
   [  212.807304] ivtv1: Stream encoder PCM: status 0x0000, 0% of 643
KiB (143 buffers) in use
   [  212.807305] ivtv1: Read MPG/VBI: 65054720/0 bytes
   [  212.807306] ivtv1: ==================  END STATUS  ==================

The 3.10.7 kernel has extra wm8775 parameters and  cx25840 parameters
than 2.6.35.

Any clues from above?

Unfortunately, i cannot do a git bisect since it is a remote system
with a slow internet connection.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-10 21:00   ` Rajil Saraswat
@ 2013-10-12 23:23     ` Andy Walls
  2013-10-13 12:49       ` Andy Walls
  0 siblings, 1 reply; 18+ messages in thread
From: Andy Walls @ 2013-10-12 23:23 UTC (permalink / raw)
  To: Rajil Saraswat; +Cc: linux-media, Hans Verkuil

On Thu, 2013-10-10 at 22:00 +0100, Rajil Saraswat wrote:
> On 10 October 2013 03:20, Andy Walls <awalls@md.metrocast.net> wrote:
> > On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote:
> >> Hi,
> >>
> >>  I have a couple of PVR-500's which have additional tuners connected
> >> to them (using daughter cards).
> >
> > The PVR-500's don't have daughter cards with additional tuners AFAIK.
> >
> > There is this however:
> > http://www.hauppauge.com/site/webstore2/webstore_avcable-pci.asp
> >
> > Make sure you have any jumpers set properly and the cable connectors
> > seated properly.
> >
> > Also make sure the cable is routed aways from any electrically noisy
> > cards and high speed data busses: disk controller cards, graphics cards,
> > etc.
> >
> >>  The audio is not usable on either
> >> 1.4.2 or 1.4.3 ivtv drivers. The issue is described at
> >> http://ivtvdriver.org/pipermail/ivtv-users/2013-September/010462.html
> >
> > With your previous working kernel and with the non-working kernel, what
> > is the output of
> >
> > $ v4l2-ctl -d /dev/videoX --log-status
> >
> > after you have set up the inputs properly and have a known good signal
> > going into the input in question?
> >
> > I'm speculating this is a problem with the cx25840 driver or the wm8775
> > driver, since they change more often than the ivtv driver.
> 
> Yes, thats right it is a set of extra inputs and not a separate tuner
> card. I played a video stream fro both kernels. Here are the logs
> 
> Working kernel 2.6.35
>  v4l2-ctl -d /dev/video1 --log-status
> 
> Status Log:
> 
>    [50885.487963] ivtv1: =================  START STATUS CARD #1
> =================
>    [50885.487967] ivtv1: Version: 1.4.1 Card: WinTV PVR 500 (unit #2)
[snip]
>    [50885.545429] cx25840 2-0044: Video signal:              present
>    [50885.545431] cx25840 2-0044: Detected format:           PAL-BDGHI
>    [50885.545433] cx25840 2-0044: Specified standard:        PAL-BDGHI
>    [50885.545435] cx25840 2-0044: Specified video input:     Composite 4
>    [50885.545437] cx25840 2-0044: Specified audioclock freq: 48000 Hz
[snip]
>    [50885.553121] ivtv1: ==================  END STATUS CARD #1
> ==================
> 
> For the non-working kernel 2.6.37
> 
>    [  212.730996] ivtv1: =================  START STATUS  =================
>    [  212.731001] ivtv1: Version: 1.4.3 Card: WinTV PVR 500 (unit #2)
[snip]
>    [  212.787820] cx25840 2-0044: Video signal:              present
>    [  212.787822] cx25840 2-0044: Detected format:           PAL-BDGHI
>    [  212.787823] cx25840 2-0044: Specified standard:        PAL-BDGHI
>    [  212.787824] cx25840 2-0044: Specified video input:     Composite 4
[snip]

Hmm.  I have a PVR-500, with the extra input cable hooked up to unit #2
of the PVR-500 and a DTV-to-CVBS converter box connected.

My CVBS signal shows up when I am set to PVR-500  'Input 2, Composite 1'
which is cx25840 'Composite 3'.  This makes sense for unit #2 of a
PVR-500. It must have the white connector wired differently from unit #1
of the PVR-500 (and from the PVR-150), since the PVR-500 unit #2 doesn't
have a CVBS input connector on the main card.

Are you sure you have the input like this and obtain good video from
PVR-500 unit #2, when it is set to 'Input 4, Composite 2', cx25840
'Composite 4'?

Could you try recording with PVR unit #2 set to 'Input 2, Composite 1',
cx25840 'Composite 3'?  

These are the questions in my mind:

Is your PVR-500 unit #2 wired differently than mine?
Are the older kernels more forgiving when capturing audio with the wrong
input set? (Try both Input 2 and Input 4 with both kernels.)

> The 3.10.7 kernel has extra wm8775 parameters and  cx25840 parameters
> than 2.6.35.

The cx25840 blurts out IR unit status (ignore it) and the cx5840 user
controls (Volume, Balance, etc.) a little differently,

> Any clues from above?

No.  They look the same for everything that matters.

Regards,
Andy

> Unfortunately, i cannot do a git bisect since it is a remote system
> with a slow internet connection.



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-12 23:23     ` Andy Walls
@ 2013-10-13 12:49       ` Andy Walls
  2013-10-13 19:14         ` Rajil Saraswat
  0 siblings, 1 reply; 18+ messages in thread
From: Andy Walls @ 2013-10-13 12:49 UTC (permalink / raw)
  To: Rajil Saraswat; +Cc: linux-media, Hans Verkuil

On Sat, 2013-10-12 at 19:23 -0400, Andy Walls wrote:
> On Thu, 2013-10-10 at 22:00 +0100, Rajil Saraswat wrote:
> > On 10 October 2013 03:20, Andy Walls <awalls@md.metrocast.net> wrote:
> > > On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote:
> > >> Hi,
> > >>
> > >>  I have a couple of PVR-500's which have additional tuners connected
> > >> to them (using daughter cards).
> > >
> > > The PVR-500's don't have daughter cards with additional tuners AFAIK.
> > >
> > > There is this however:
> > > http://www.hauppauge.com/site/webstore2/webstore_avcable-pci.asp
> > >
[snip]
> > >
> > >>  The audio is not usable on either
> > >> 1.4.2 or 1.4.3 ivtv drivers. The issue is described at
> > >> http://ivtvdriver.org/pipermail/ivtv-users/2013-September/010462.html
> > >
> > > With your previous working kernel and with the non-working kernel, what
> > > is the output of
> > >
> > > $ v4l2-ctl -d /dev/videoX --log-status
> > >
> > > after you have set up the inputs properly and have a known good signal
> > > going into the input in question?
> > >
> > > I'm speculating this is a problem with the cx25840 driver or the wm8775
> > > driver, since they change more often than the ivtv driver.
> > 
> > Yes, thats right it is a set of extra inputs and not a separate tuner
> > card. I played a video stream fro both kernels. Here are the logs
> > 
> > Working kernel 2.6.35
> >  v4l2-ctl -d /dev/video1 --log-status
> > 
> > Status Log:
> > 
> >    [50885.487963] ivtv1: =================  START STATUS CARD #1
> > =================
> >    [50885.487967] ivtv1: Version: 1.4.1 Card: WinTV PVR 500 (unit #2)
> [snip]
> >    [50885.545429] cx25840 2-0044: Video signal:              present
> >    [50885.545431] cx25840 2-0044: Detected format:           PAL-BDGHI
> >    [50885.545433] cx25840 2-0044: Specified standard:        PAL-BDGHI
> >    [50885.545435] cx25840 2-0044: Specified video input:     Composite 4
> >    [50885.545437] cx25840 2-0044: Specified audioclock freq: 48000 Hz
> [snip]
> >    [50885.553121] ivtv1: ==================  END STATUS CARD #1
> > ==================
> > 
> > For the non-working kernel 2.6.37
> > 
> >    [  212.730996] ivtv1: =================  START STATUS  =================
> >    [  212.731001] ivtv1: Version: 1.4.3 Card: WinTV PVR 500 (unit #2)
> [snip]
> >    [  212.787820] cx25840 2-0044: Video signal:              present
> >    [  212.787822] cx25840 2-0044: Detected format:           PAL-BDGHI
> >    [  212.787823] cx25840 2-0044: Specified standard:        PAL-BDGHI
> >    [  212.787824] cx25840 2-0044: Specified video input:     Composite 4
> [snip]
> 
> Hmm.  I have a PVR-500, with the extra input cable hooked up to unit #2
> of the PVR-500 and a DTV-to-CVBS converter box connected.
> 
> My CVBS signal shows up when I am set to PVR-500  'Input 2, Composite 1'
> which is cx25840 'Composite 3'.  This makes sense for unit #2 of a
> PVR-500. It must have the white connector wired differently from unit #1
> of the PVR-500 (and from the PVR-150), since the PVR-500 unit #2 doesn't
> have a CVBS input connector on the main card.
> 
> Are you sure you have the input like this and obtain good video from
> PVR-500 unit #2, when it is set to 'Input 4, Composite 2', cx25840
> 'Composite 4'?
> 
> Could you try recording with PVR unit #2 set to 'Input 2, Composite 1',
> cx25840 'Composite 3'?  
> 
> These are the questions in my mind:
> 
> Is your PVR-500 unit #2 wired differently than mine?
> Are the older kernels more forgiving when capturing audio with the wrong
> input set? (Try both Input 2 and Input 4 with both kernels.)


OK, I just tested with my Wii game console connected to the PVR-500 unit
#2, Fedora 17, kernel 3.6.10-2.fc17.x86_64.

1. With the unit set to 'Input 2, Composite 1', cx25840 'Composite 3':
Good video, good audio

2. With the unit set to 'Input 4, Composite 2', cx25840 'Composite 4':
No video, distorted audio.

AFAICT:
You're using the wrong input.
You weren't checking the video, only the audio.

I consider this problem resolved.


> > Unfortunately, i cannot do a git bisect since it is a remote system
> > with a slow internet connection.

Is this system for personal or professional use?  I don't know of any
home users who have remote sites.

If for professional use, I'd suggest your employer pay a consultant, if
the company/university/whatever can't do a git bisect on a development
system in house.

-Andy


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-13 12:49       ` Andy Walls
@ 2013-10-13 19:14         ` Rajil Saraswat
  2013-10-13 23:43           ` Andy Walls
  0 siblings, 1 reply; 18+ messages in thread
From: Rajil Saraswat @ 2013-10-13 19:14 UTC (permalink / raw)
  To: Andy Walls; +Cc: linux-media, Hans Verkuil

> OK, I just tested with my Wii game console connected to the PVR-500 unit
> #2, Fedora 17, kernel 3.6.10-2.fc17.x86_64.
>
> 1. With the unit set to 'Input 2, Composite 1', cx25840 'Composite 3':
> Good video, good audio
>
> 2. With the unit set to 'Input 4, Composite 2', cx25840 'Composite 4':
> No video, distorted audio.
>

This is what i used to changed the input

v4l2-ctl -d /dev/video1 --set-input 4

With this 2.6.35 gives me perfect video/audio. Kernel 3.10.7 on the
other hand gives good video but distorted audio. On this cards primary
input (/dev/video0), i use the radio so i cant use input 2 of this
card. My composite cable is connected to the 'extra-input' card which
should be composite 2.

My understanding is input 4 is #2 composite, and input 2 is #1
composite. Is that not right?

This is what i tried in kernel 2.6.35:

1. v4l2-ctl -d /dev/video1 --set-input 2
Video input set to 2 (Composite 1: ok)
No video

2. v4l2-ctl -d /dev/video1 --set-input 4
Video input set to 4 (Composite 2: ok)
Good video

As i mentioned in kernel 2.6.35, mythtv/mplayer give me both good
video/audio if i use 2 above.

> AFAICT:
> You're using the wrong input.
> You weren't checking the video, only the audio.

What inputs do you think i should use with v4l2-ctl?


>> > Unfortunately, i cannot do a git bisect since it is a remote system
>> > with a slow internet connection.
>
> Is this system for personal or professional use?  I don't know of any
> home users who have remote sites.

Your know one user now!. Yes it is for personal use. It was for my old
folks who live in another country and i manage their mythtv/htpc
remotely.

-Rajil

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-13 19:14         ` Rajil Saraswat
@ 2013-10-13 23:43           ` Andy Walls
  2013-10-16  0:10             ` Rajil Saraswat
  0 siblings, 1 reply; 18+ messages in thread
From: Andy Walls @ 2013-10-13 23:43 UTC (permalink / raw)
  To: Rajil Saraswat; +Cc: linux-media, Hans Verkuil

On Sun, 2013-10-13 at 20:14 +0100, Rajil Saraswat wrote:
> > OK, I just tested with my Wii game console connected to the PVR-500 unit
> > #2, Fedora 17, kernel 3.6.10-2.fc17.x86_64.
> >
> > 1. With the unit set to 'Input 2, Composite 1', cx25840 'Composite 3':
> > Good video, good audio
> >
> > 2. With the unit set to 'Input 4, Composite 2', cx25840 'Composite 4':
> > No video, distorted audio.
> >
> 
> This is what i used to changed the input
> 
> v4l2-ctl -d /dev/video1 --set-input 4
> 
> With this 2.6.35 gives me perfect video/audio. Kernel 3.10.7 on the
> other hand gives good video but distorted audio. On this cards primary
> input (/dev/video0), i use the radio so i cant use input 2 of this
> card. My composite cable is connected to the 'extra-input' card which
> should be composite 2.
> 
> My understanding is input 4 is #2 composite, and input 2 is #1
> composite. Is that not right?

For my PVR-500, it doesn't appear to be.  Here's how I believ it is
wired up:

PVR-500 Left/First half (aka Unit #1)
Tuner TV Composite out          ---> CX25843 Analog Input 7    --+ 
SVideo 1    (rear bracket)      ---> CX25843 Analog Inputs 1,5 --+
Composite 1 (rear bracket)      ---> CX25843 Analog Input 3    --+-- CX25843 VIP out --> CX23416 VIP In
SVideo 2    (white connector)   ---> CX25843 Analog Inputs 2,6 --+
Composite 2 (white connector)   ---> CX25843 Analog Input 4    --+

Tuner SIF audio out           ---> CX25843 Analog Input 8    --------------------------------+  
                                                                                             |  
Tuner TV mono-audio out       ---> WM8775 AIN1 L,R --+                                       |  
Audio 1 L,R (rear bracket)    ---> WM8775 AIN2 L,R --+- WM8775 I2S out --> CX25843 I2S 1 In -+-> CX25843 I2S out --> CX23416 I2S In
Audio 2 L,R (white connector) ---> WM8775 AIN3 L,R --+
Tuner FM audio out L,R        ---> WM8775 AIN4 L,R --+


PVR-500 Right/Second half (aka Unit #2)
Tuner TV Composite out          ---> CX25843 Analog Input 7    --+ 
SVideo 1    (white connector)   ---> CX25843 Analog Inputs 1,5 --+
Composite 1 (white connector)   ---> CX25843 Analog Input 3    --+-- CX25843 VIP out --> CX23416 VIP In

Tuner SIF audio out           ---> CX25843 Analog Input 8    --------------------------------+  
                                                                                             |  
Tuner TV mono-audio out       ---> WM8775 AIN1 L,R --+                                       |  
Audio 1 L,R (white connector) ---> WM8775 AIN2 L,R --+- WM8775 I2S out --> CX25843 I2S 1 In -+-> CX25843 I2S out --> CX23416 I2S In

So for my PVR-500,
unit #1 Composite 1 is on the card's bracket.
unit #1 Composite 2 is on the white connector.
unit #2 Composite 1 is on the white connector.
unit #2 Composite 2 is not available


> This is what i tried in kernel 2.6.35:
> 
> 1. v4l2-ctl -d /dev/video1 --set-input 2
> Video input set to 2 (Composite 1: ok)
> No video
> 
> 2. v4l2-ctl -d /dev/video1 --set-input 4
> Video input set to 4 (Composite 2: ok)
> Good video

If /dev/video1 referes to unit #2 of your PVR-500 (according to v4l2-ctl
-d /dev/video1 --log-status) then it appears your unit is wired
differently than mine.


> As i mentioned in kernel 2.6.35, mythtv/mplayer give me both good
> video/audio if i use 2 above.

$ git diff --color v2.6.35 v2.6.37 drivers/media/video/wm8775.c

Shows me no really good reason why the wm8775 driver should have broken.

$ git diff --color v2.6.35 v2.6.37 drivers/media/video/cx25840/*[ch]

Show a few conceptually simple changes to the cx25840 driver.  Something
may have broken, but I doubt it.

$ git diff --color v2.6.35 v2.6.37 drivers/media/video/cx2341x.c

Shows changes to the control handling.  The ones regarding audio
sampling frequency may be at fault.

$ git diff --color v2.6.35 v2.6.37 drivers/media/video/ivtv/ivtv*[ch]

Shows changes to the irq handling and the control handling.  Again the
controls realted to audio mode and audio sampling rate stand out as
potential causes.

None of the above changes would explain to me why audio on input 3 of
the WM8775 works (for me) but audio on input 4 of the WM8775 does not
work (for you).

I'll have to try additional tests with unit #1 of my PVR-500 later this
week.

> > AFAICT:
> > You're using the wrong input.
> > You weren't checking the video, only the audio.
> 
> What inputs do you think i should use with v4l2-ctl?

I have no recommendation at the moment.

If you can do a git bisect please try.
There are 11,117 commits to bisect: that's 15 steps.  Each
bisect/compile/install/test iteration I would estimate takes about 2
hours.

If I can reproduce your problem on a PVR-150 or on unit #1 of my
PVR-500, then I can try to bisect.  But I have no idea when I would have
time to perform the bisection.


> >> > Unfortunately, i cannot do a git bisect since it is a remote system
> >> > with a slow internet connection.
> >
> > Is this system for personal or professional use?  I don't know of any
> > home users who have remote sites.
> 
> Your know one user now!. Yes it is for personal use. It was for my old
> folks who live in another country and i manage their mythtv/htpc
> remotely.

Ah.

-Regards,
Andy

> -Rajil



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-13 23:43           ` Andy Walls
@ 2013-10-16  0:10             ` Rajil Saraswat
  2013-10-19 17:09               ` Andy Walls
  0 siblings, 1 reply; 18+ messages in thread
From: Rajil Saraswat @ 2013-10-16  0:10 UTC (permalink / raw)
  To: Andy Walls; +Cc: linux-media, Hans Verkuil

I was finally able to carry out a git bisect. Had to do a git pull on
a fast internet hooked machine and ftp the files over to the remote
machine.

I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'.

And the result was:

5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit
commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79
Author: Hans Verkuil <hverkuil@xs4all.nl>
Date:   Sat Apr 24 08:23:53 2010 -0300

    V4L/DVB: wm8775: convert to the new control framework

    Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

:040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055
2f094df6f65d7fb296657619c1ad6f93fe085a75 M    drivers

I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo
sources, and confirmed that video/audio now works fine on v4l2-ctl -d
/dev/video1 --set-input 4

I wasnt able to remove the patch in 3.10.7 which is gentoo stable
kernel. Any idea how can i do that?

Regards
Rajil

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-16  0:10             ` Rajil Saraswat
@ 2013-10-19 17:09               ` Andy Walls
  2013-10-20 17:47                 ` Rajil Saraswat
                                   ` (2 more replies)
  0 siblings, 3 replies; 18+ messages in thread
From: Andy Walls @ 2013-10-19 17:09 UTC (permalink / raw)
  To: Rajil Saraswat; +Cc: linux-media, Hans Verkuil

On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
> I was finally able to carry out a git bisect. Had to do a git pull on
> a fast internet hooked machine and ftp the files over to the remote
> machine.
> 
> I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'.
> 
> And the result was:
> 
> 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit
> commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79
> Author: Hans Verkuil <hverkuil@xs4all.nl>
> Date:   Sat Apr 24 08:23:53 2010 -0300
> 
>     V4L/DVB: wm8775: convert to the new control framework
> 
>     Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> 
> :040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055
> 2f094df6f65d7fb296657619c1ad6f93fe085a75 M    drivers
> 
> I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo
> sources, and confirmed that video/audio now works fine on v4l2-ctl -d
> /dev/video1 --set-input 4
> 
> I wasnt able to remove the patch in 3.10.7 which is gentoo stable
> kernel. Any idea how can i do that?

Try applying the following (untested) patch that is made against the
bleeding edge Linux kernel.  The test on the mute control state in
wm8775_s_routing() appears to have been inverted in the bad commit you
isolated.

Along with '--set-input', you may also want to use v4l2-ctl to exercise
the mute control as well, to see if it works as expected, once this
patch is applied.

Regards,
Andy

file: wm8775_s_route_mute_test_inverted.patch

diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
index 3f584a7..bee7946 100644
--- a/drivers/media/i2c/wm8775.c
+++ b/drivers/media/i2c/wm8775.c
@@ -130,12 +130,10 @@ static int wm8775_s_routing(struct v4l2_subdev *sd,
 		return -EINVAL;
 	}
 	state->input = input;
-	if (!v4l2_ctrl_g_ctrl(state->mute))
+	if (v4l2_ctrl_g_ctrl(state->mute))
 		return 0;
 	if (!v4l2_ctrl_g_ctrl(state->vol))
 		return 0;
-	if (!v4l2_ctrl_g_ctrl(state->bal))
-		return 0;
 	wm8775_set_audio(sd, 1);
 	return 0;
 }



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-19 17:09               ` Andy Walls
@ 2013-10-20 17:47                 ` Rajil Saraswat
  2013-11-04 12:44                 ` Hans Verkuil
  2013-11-11 11:14                 ` Hans Verkuil
  2 siblings, 0 replies; 18+ messages in thread
From: Rajil Saraswat @ 2013-10-20 17:47 UTC (permalink / raw)
  To: Andy Walls; +Cc: linux-media, Hans Verkuil

On 19 October 2013 18:09, Andy Walls <awalls@md.metrocast.net> wrote:
> On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
>> I was finally able to carry out a git bisect. Had to do a git pull on
>> a fast internet hooked machine and ftp the files over to the remote
>> machine.
>>
>> I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'.
>>
>> And the result was:
>>
>> 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit
>> commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79
>> Author: Hans Verkuil <hverkuil@xs4all.nl>
>> Date:   Sat Apr 24 08:23:53 2010 -0300
>>
>>     V4L/DVB: wm8775: convert to the new control framework
>>
>>     Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> :040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055
>> 2f094df6f65d7fb296657619c1ad6f93fe085a75 M    drivers
>>
>> I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo
>> sources, and confirmed that video/audio now works fine on v4l2-ctl -d
>> /dev/video1 --set-input 4
>>
>> I wasnt able to remove the patch in 3.10.7 which is gentoo stable
>> kernel. Any idea how can i do that?
>
> Try applying the following (untested) patch that is made against the
> bleeding edge Linux kernel.  The test on the mute control state in
> wm8775_s_routing() appears to have been inverted in the bad commit you
> isolated.
>
> Along with '--set-input', you may also want to use v4l2-ctl to exercise
> the mute control as well, to see if it works as expected, once this
> patch is applied.
>
> Regards,
> Andy
>
> file: wm8775_s_route_mute_test_inverted.patch
>
> diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
> index 3f584a7..bee7946 100644
> --- a/drivers/media/i2c/wm8775.c
> +++ b/drivers/media/i2c/wm8775.c
> @@ -130,12 +130,10 @@ static int wm8775_s_routing(struct v4l2_subdev *sd,
>                 return -EINVAL;
>         }
>         state->input = input;
> -       if (!v4l2_ctrl_g_ctrl(state->mute))
> +       if (v4l2_ctrl_g_ctrl(state->mute))
>                 return 0;
>         if (!v4l2_ctrl_g_ctrl(state->vol))
>                 return 0;
> -       if (!v4l2_ctrl_g_ctrl(state->bal))
> -               return 0;
>         wm8775_set_audio(sd, 1);
>         return 0;
>  }
>
>

Thanks for the patch. Unfortunately, my htpc has been kicked off the
network when the attached TV died. It will take me few weeks to get it
up again. But I will try this patch when things are back normal and
report back.

-Rajil

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-19 17:09               ` Andy Walls
  2013-10-20 17:47                 ` Rajil Saraswat
@ 2013-11-04 12:44                 ` Hans Verkuil
  2013-11-06  0:25                   ` Andy Walls
  2013-11-11 11:14                 ` Hans Verkuil
  2 siblings, 1 reply; 18+ messages in thread
From: Hans Verkuil @ 2013-11-04 12:44 UTC (permalink / raw)
  To: Andy Walls; +Cc: Rajil Saraswat, linux-media

On 10/19/2013 07:09 PM, Andy Walls wrote:
> On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
>> I was finally able to carry out a git bisect. Had to do a git pull on
>> a fast internet hooked machine and ftp the files over to the remote
>> machine.
>>
>> I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'.
>>
>> And the result was:
>>
>> 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit
>> commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79
>> Author: Hans Verkuil <hverkuil@xs4all.nl>
>> Date:   Sat Apr 24 08:23:53 2010 -0300
>>
>>     V4L/DVB: wm8775: convert to the new control framework
>>
>>     Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> :040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055
>> 2f094df6f65d7fb296657619c1ad6f93fe085a75 M    drivers
>>
>> I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo
>> sources, and confirmed that video/audio now works fine on v4l2-ctl -d
>> /dev/video1 --set-input 4
>>
>> I wasnt able to remove the patch in 3.10.7 which is gentoo stable
>> kernel. Any idea how can i do that?
> 
> Try applying the following (untested) patch that is made against the
> bleeding edge Linux kernel.  The test on the mute control state in
> wm8775_s_routing() appears to have been inverted in the bad commit you
> isolated.

Aargh! I'm pretty sure that's the culprit. Man, that's been broken for ages.
I'll see if I can test this patch this week.

Regards,

	Hans

> Along with '--set-input', you may also want to use v4l2-ctl to exercise
> the mute control as well, to see if it works as expected, once this
> patch is applied.
> 
> Regards,
> Andy
> 
> file: wm8775_s_route_mute_test_inverted.patch
> 
> diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
> index 3f584a7..bee7946 100644
> --- a/drivers/media/i2c/wm8775.c
> +++ b/drivers/media/i2c/wm8775.c
> @@ -130,12 +130,10 @@ static int wm8775_s_routing(struct v4l2_subdev *sd,
>  		return -EINVAL;
>  	}
>  	state->input = input;
> -	if (!v4l2_ctrl_g_ctrl(state->mute))
> +	if (v4l2_ctrl_g_ctrl(state->mute))
>  		return 0;
>  	if (!v4l2_ctrl_g_ctrl(state->vol))
>  		return 0;
> -	if (!v4l2_ctrl_g_ctrl(state->bal))
> -		return 0;
>  	wm8775_set_audio(sd, 1);
>  	return 0;
>  }
> 
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-11-04 12:44                 ` Hans Verkuil
@ 2013-11-06  0:25                   ` Andy Walls
  2013-11-11 11:07                     ` Hans Verkuil
  0 siblings, 1 reply; 18+ messages in thread
From: Andy Walls @ 2013-11-06  0:25 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: Rajil Saraswat, linux-media

On Mon, 2013-11-04 at 13:44 +0100, Hans Verkuil wrote:
> On 10/19/2013 07:09 PM, Andy Walls wrote:
> > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:

> > Try applying the following (untested) patch that is made against the
> > bleeding edge Linux kernel.  The test on the mute control state in
> > wm8775_s_routing() appears to have been inverted in the bad commit you
> > isolated.
> 
> Aargh! I'm pretty sure that's the culprit. Man, that's been broken for ages.

Hi Hans,

Yes, and only *one* person reported it in those years.  I suspect very
few people use the comination of conventional PCI, analog video, and
SVideo 2 or Composite 2 anymore.


> I'll see if I can test this patch this week.

Thanks!  I'm very busy at work until mid-December.

Regards,
Andy


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-11-06  0:25                   ` Andy Walls
@ 2013-11-11 11:07                     ` Hans Verkuil
  0 siblings, 0 replies; 18+ messages in thread
From: Hans Verkuil @ 2013-11-11 11:07 UTC (permalink / raw)
  To: Andy Walls; +Cc: Rajil Saraswat, linux-media

On 11/06/2013 01:25 AM, Andy Walls wrote:
> On Mon, 2013-11-04 at 13:44 +0100, Hans Verkuil wrote:
>> On 10/19/2013 07:09 PM, Andy Walls wrote:
>>> On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
> 
>>> Try applying the following (untested) patch that is made against the
>>> bleeding edge Linux kernel.  The test on the mute control state in
>>> wm8775_s_routing() appears to have been inverted in the bad commit you
>>> isolated.
>>
>> Aargh! I'm pretty sure that's the culprit. Man, that's been broken for ages.
> 
> Hi Hans,
> 
> Yes, and only *one* person reported it in those years.  I suspect very
> few people use the comination of conventional PCI, analog video, and
> SVideo 2 or Composite 2 anymore.
> 
> 
>> I'll see if I can test this patch this week.
> 
> Thanks!  I'm very busy at work until mid-December.

I finally managed to test this and this patch does indeed fix the bug. I'll make
a pull request for this.

Regards,

	Hans

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-10-19 17:09               ` Andy Walls
  2013-10-20 17:47                 ` Rajil Saraswat
  2013-11-04 12:44                 ` Hans Verkuil
@ 2013-11-11 11:14                 ` Hans Verkuil
  2013-11-11 13:42                   ` Andy Walls
  2 siblings, 1 reply; 18+ messages in thread
From: Hans Verkuil @ 2013-11-11 11:14 UTC (permalink / raw)
  To: Andy Walls; +Cc: Rajil Saraswat, linux-media

On 10/19/2013 07:09 PM, Andy Walls wrote:
> On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
>> I was finally able to carry out a git bisect. Had to do a git pull on
>> a fast internet hooked machine and ftp the files over to the remote
>> machine.
>>
>> I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'.
>>
>> And the result was:
>>
>> 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit
>> commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79
>> Author: Hans Verkuil <hverkuil@xs4all.nl>
>> Date:   Sat Apr 24 08:23:53 2010 -0300
>>
>>     V4L/DVB: wm8775: convert to the new control framework
>>
>>     Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> :040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055
>> 2f094df6f65d7fb296657619c1ad6f93fe085a75 M    drivers
>>
>> I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo
>> sources, and confirmed that video/audio now works fine on v4l2-ctl -d
>> /dev/video1 --set-input 4
>>
>> I wasnt able to remove the patch in 3.10.7 which is gentoo stable
>> kernel. Any idea how can i do that?
> 
> Try applying the following (untested) patch that is made against the
> bleeding edge Linux kernel.  The test on the mute control state in
> wm8775_s_routing() appears to have been inverted in the bad commit you
> isolated.

Can you give me your Signed-off-by?

Thanks!

	Hans

> 
> Along with '--set-input', you may also want to use v4l2-ctl to exercise
> the mute control as well, to see if it works as expected, once this
> patch is applied.
> 
> Regards,
> Andy
> 
> file: wm8775_s_route_mute_test_inverted.patch
> 
> diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
> index 3f584a7..bee7946 100644
> --- a/drivers/media/i2c/wm8775.c
> +++ b/drivers/media/i2c/wm8775.c
> @@ -130,12 +130,10 @@ static int wm8775_s_routing(struct v4l2_subdev *sd,
>  		return -EINVAL;
>  	}
>  	state->input = input;
> -	if (!v4l2_ctrl_g_ctrl(state->mute))
> +	if (v4l2_ctrl_g_ctrl(state->mute))
>  		return 0;
>  	if (!v4l2_ctrl_g_ctrl(state->vol))
>  		return 0;
> -	if (!v4l2_ctrl_g_ctrl(state->bal))
> -		return 0;
>  	wm8775_set_audio(sd, 1);
>  	return 0;
>  }
> 
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
  2013-11-11 11:14                 ` Hans Verkuil
@ 2013-11-11 13:42                   ` Andy Walls
  0 siblings, 0 replies; 18+ messages in thread
From: Andy Walls @ 2013-11-11 13:42 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: Rajil Saraswat, linux-media

On Mon, 2013-11-11 at 12:14 +0100, Hans Verkuil wrote:
> On 10/19/2013 07:09 PM, Andy Walls wrote:
> > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
> >> I was finally able to carry out a git bisect. Had to do a git pull on
> >> a fast internet hooked machine and ftp the files over to the remote
> >> machine.
> >>
> >> I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'.
> >>
> >> And the result was:
> >>
> >> 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit
> >> commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79
> >> Author: Hans Verkuil <hverkuil@xs4all.nl>
> >> Date:   Sat Apr 24 08:23:53 2010 -0300
> >>
> >>     V4L/DVB: wm8775: convert to the new control framework
> >>
> >>     Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
> >>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> >>
> >> :040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055
> >> 2f094df6f65d7fb296657619c1ad6f93fe085a75 M    drivers
> >>
> >> I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo
> >> sources, and confirmed that video/audio now works fine on v4l2-ctl -d
> >> /dev/video1 --set-input 4
> >>
> >> I wasnt able to remove the patch in 3.10.7 which is gentoo stable
> >> kernel. Any idea how can i do that?
> > 
> > Try applying the following (untested) patch that is made against the
> > bleeding edge Linux kernel.  The test on the mute control state in
> > wm8775_s_routing() appears to have been inverted in the bad commit you
> > isolated.
> 
> Can you give me your Signed-off-by?


Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Bisected-by: Rajil Saraswat <rajil.s@gmail.com>
Reported-by: Rajil Saraswat <rajil.s@gmail.com>

> Thanks!
> 
> 	Hans
> 
> > 
> > Along with '--set-input', you may also want to use v4l2-ctl to exercise
> > the mute control as well, to see if it works as expected, once this
> > patch is applied.
> > 
> > Regards,
> > Andy
> > 
> > file: wm8775_s_route_mute_test_inverted.patch
> > 
> > diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
> > index 3f584a7..bee7946 100644
> > --- a/drivers/media/i2c/wm8775.c
> > +++ b/drivers/media/i2c/wm8775.c
> > @@ -130,12 +130,10 @@ static int wm8775_s_routing(struct v4l2_subdev *sd,
> >  		return -EINVAL;
> >  	}
> >  	state->input = input;
> > -	if (!v4l2_ctrl_g_ctrl(state->mute))
> > +	if (v4l2_ctrl_g_ctrl(state->mute))
> >  		return 0;
> >  	if (!v4l2_ctrl_g_ctrl(state->vol))
> >  		return 0;
> > -	if (!v4l2_ctrl_g_ctrl(state->bal))
> > -		return 0;
> >  	wm8775_set_audio(sd, 1);
> >  	return 0;
> >  }
> > 
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2013-11-11 13:40 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 20:49 ivtv 1.4.2/1.4.3 broken in recent kernels? Rajil Saraswat
2013-09-30 11:33 ` Hans Verkuil
2013-10-05 13:10   ` Rajil Saraswat
     [not found]     ` <CAFoaQoDS6LUKNQ7dHF1s1Ms_YuS98mZzrhXRjLLarHHUxsSxMQ@mail.gmail.com>
2013-10-07 15:01       ` Rajil Saraswat
2013-10-10  2:20 ` Andy Walls
2013-10-10 21:00   ` Rajil Saraswat
2013-10-12 23:23     ` Andy Walls
2013-10-13 12:49       ` Andy Walls
2013-10-13 19:14         ` Rajil Saraswat
2013-10-13 23:43           ` Andy Walls
2013-10-16  0:10             ` Rajil Saraswat
2013-10-19 17:09               ` Andy Walls
2013-10-20 17:47                 ` Rajil Saraswat
2013-11-04 12:44                 ` Hans Verkuil
2013-11-06  0:25                   ` Andy Walls
2013-11-11 11:07                     ` Hans Verkuil
2013-11-11 11:14                 ` Hans Verkuil
2013-11-11 13:42                   ` Andy Walls

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox