public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: "edubezval@gmail.com" <edubezval@gmail.com>
Cc: Dinesh Ram <dinesh.ram@cern.ch>,
	Linux-Media <linux-media@vger.kernel.org>,
	d ram <dinesh.ram086@gmail.com>
Subject: Re: [Review Patch 0/9] si4713 usb device driver
Date: Mon, 04 Nov 2013 15:13:55 +0100	[thread overview]
Message-ID: <5277ABA3.3060703@xs4all.nl> (raw)
In-Reply-To: <CAC-25o9FqkS_g_-RAFn6UuGqKKBhazxtorqzyt=R8ZNDQN23Tw@mail.gmail.com>

On 11/04/2013 03:09 PM, edubezval@gmail.com wrote:
> Hans,
> 
> On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On 10/15/2013 07:37 PM, edubezval@gmail.com wrote:
>>> Hello Dinesh,
>>>
>>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram <dinesh.ram@cern.ch> wrote:
>>>> Hello Eduardo,
>>>>
>>>> In this patch series, I have addressed the comments by you
>>>> concerning my last patch series.
>>>> In the resulting patches, I have corrected most of the
>>>> style issues and adding of comments. However, some warnings
>>>> given out by checkpatch.pl (mostly complaing about lines longer
>>>> than 80 characters) are still there because I saw that code readibility
>>>> suffers by breaking up those lines.
>>>>
>>>> Also Hans has contributed patches 8 and 9 in this patch series
>>>> which address the issues of the handling of unknown regulators,
>>>> which have apparently changed since 3.10. Hans has tested it and the
>>>> driver loads again.
>>>>
>>>> Let me know when you are able to test it again.
>>>>
>>>
>>> Hopefully I will be able to give it a shot on n900 and on silabs
>>> devboard until the end of the week. Thanks for not giving up.
>>
>> Did you find time to do this? I'm waiting for feedback from you.
> 
> sorry for the late answer, I was offline for two weeks taking care of
> my newborn  son :-).

An excellent reason! Congratulations!

	Hans

> 
> I am giving the series a second shot.
> 
>>
>> Regards,
>>
>>         Hans
> 
> 
> 


  reply	other threads:[~2013-11-04 14:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 15:24 [Review Patch 0/9] si4713 usb device driver Dinesh Ram
2013-10-15 15:24 ` [REVIEW PATCH 1/9] si4713 : Reorganized drivers/media/radio directory Dinesh Ram
2013-10-15 15:24   ` [REVIEW PATCH 2/9] si4713 : Modified i2c driver to handle cases where interrupts are not used Dinesh Ram
2013-12-03 15:35     ` Mauro Carvalho Chehab
2013-12-03 17:06       ` Hans Verkuil
     [not found]         ` <1386129496.79520.YahooMailNeo@web190906.mail.sg3.yahoo.com>
2013-12-04 17:42           ` Mauro Carvalho Chehab
2013-12-05  7:39           ` Hans Verkuil
2013-10-15 15:24   ` [REVIEW PATCH 3/9] si4713 : Reorganized includes in si4713.c/h Dinesh Ram
2013-10-15 15:24   ` [REVIEW PATCH 4/9] si4713 : Bug fix for si4713_tx_tune_power() method in the i2c driver Dinesh Ram
2013-10-15 15:24   ` [REVIEW PATCH 5/9] si4713 : HID blacklist Si4713 USB development board Dinesh Ram
2013-10-15 15:24   ` [REVIEW PATCH 6/9] si4713 : Added the USB driver for Si4713 Dinesh Ram
2013-11-05 14:18     ` edubezval
2013-11-07  7:40       ` Hans Verkuil
2013-11-11 12:34         ` edubezval
2013-11-18 14:47       ` edubezval
2013-10-15 15:24   ` [REVIEW PATCH 7/9] si4713 : Added MAINTAINERS entry for radio-usb-si4713 driver Dinesh Ram
2013-10-15 15:24   ` [REVIEW PATCH 8/9] si4713: move supply list to si4713_platform_data Dinesh Ram
2013-11-04 14:07     ` edubezval
2013-11-05  8:38       ` Hans Verkuil
2013-11-05 14:14         ` edubezval
2013-10-15 15:24   ` [REVIEW PATCH 9/9] si4713: si4713_set_rds_radio_text overwrites terminating \0 Dinesh Ram
2013-12-03 15:39   ` [REVIEW PATCH 1/9] si4713 : Reorganized drivers/media/radio directory Mauro Carvalho Chehab
     [not found]     ` <CAP_RhzeRgLir1FGL6UN2-yXXaS-1knsS2BP20MjfMJRAEyDqeg@mail.gmail.com>
2013-12-03 16:06       ` FW: " Dinesh Ram
2013-12-03 16:58     ` Hans Verkuil
2013-12-04 17:41       ` Mauro Carvalho Chehab
2013-10-15 17:37 ` [Review Patch 0/9] si4713 usb device driver edubezval
2013-11-04  9:33   ` Hans Verkuil
2013-11-04 14:09     ` edubezval
2013-11-04 14:13       ` Hans Verkuil [this message]
     [not found]         ` <CAP_RhzfWKc8y27uU4VXFu6cAt87NvO=BnLNq9WeGG_kpxihTKQ@mail.gmail.com>
2013-11-04 14:39           ` edubezval
2013-11-18 14:31 ` edubezval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5277ABA3.3060703@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=dinesh.ram086@gmail.com \
    --cc=dinesh.ram@cern.ch \
    --cc=edubezval@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox