* [PATCH -next] [media] v4l: ti-vpe: fix error return code in vpe_probe()
@ 2013-10-30 3:10 Wei Yongjun
2013-11-05 5:23 ` Archit Taneja
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-10-30 3:10 UTC (permalink / raw)
To: m.chehab, grant.likely, rob.herring, archit, hans.verkuil,
k.debski
Cc: yongjun_wei, linux-media
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/media/platform/ti-vpe/vpe.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c
index 4e58069..0dbfd52 100644
--- a/drivers/media/platform/ti-vpe/vpe.c
+++ b/drivers/media/platform/ti-vpe/vpe.c
@@ -2007,8 +2007,10 @@ static int vpe_probe(struct platform_device *pdev)
vpe_top_vpdma_reset(dev);
dev->vpdma = vpdma_create(pdev);
- if (IS_ERR(dev->vpdma))
+ if (IS_ERR(dev->vpdma)) {
+ ret = PTR_ERR(dev->vpdma);
goto runtime_put;
+ }
vfd = &dev->vfd;
*vfd = vpe_videodev;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] [media] v4l: ti-vpe: fix error return code in vpe_probe()
2013-10-30 3:10 [PATCH -next] [media] v4l: ti-vpe: fix error return code in vpe_probe() Wei Yongjun
@ 2013-11-05 5:23 ` Archit Taneja
0 siblings, 0 replies; 2+ messages in thread
From: Archit Taneja @ 2013-11-05 5:23 UTC (permalink / raw)
To: Wei Yongjun, m.chehab, grant.likely, rob.herring, hans.verkuil,
k.debski
Cc: yongjun_wei, linux-media
On Wednesday 30 October 2013 08:40 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Reviewed-by: Archit Taneja <archit@ti.com>
Thanks,
Archit
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/media/platform/ti-vpe/vpe.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c
> index 4e58069..0dbfd52 100644
> --- a/drivers/media/platform/ti-vpe/vpe.c
> +++ b/drivers/media/platform/ti-vpe/vpe.c
> @@ -2007,8 +2007,10 @@ static int vpe_probe(struct platform_device *pdev)
> vpe_top_vpdma_reset(dev);
>
> dev->vpdma = vpdma_create(pdev);
> - if (IS_ERR(dev->vpdma))
> + if (IS_ERR(dev->vpdma)) {
> + ret = PTR_ERR(dev->vpdma);
> goto runtime_put;
> + }
>
> vfd = &dev->vfd;
> *vfd = vpe_videodev;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-05 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 3:10 [PATCH -next] [media] v4l: ti-vpe: fix error return code in vpe_probe() Wei Yongjun
2013-11-05 5:23 ` Archit Taneja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox