From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:13788 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580Ab3KFP6r (ORCPT ); Wed, 6 Nov 2013 10:58:47 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MVU008GAN1CGQ00@mailout3.w1.samsung.com> for linux-media@vger.kernel.org; Wed, 06 Nov 2013 15:58:45 +0000 (GMT) Message-id: <527A672F.4060505@samsung.com> Date: Wed, 06 Nov 2013 16:58:39 +0100 From: Sylwester Nawrocki MIME-version: 1.0 To: Ricardo Ribalda Delgado Cc: Mauro Carvalho Chehab , Pawel Osciak , Marek Szyprowski , "open list:SAMSUNG S5P/EXYNO..." Subject: Re: [PATCH v7] videobuf2: Add missing lock held on vb2_fop_relase References: <1383752507-25902-1-git-send-email-ricardo.ribalda@gmail.com> In-reply-to: <1383752507-25902-1-git-send-email-ricardo.ribalda@gmail.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi, On 06/11/13 16:41, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda > > vb2_fop_release does not held the lock although it is modifying the > queue->owner field. > > This could lead to race conditions on the vb2_perform_io function > when multiple applications are accessing the video device via > read/write API: [...] > > Acked-by: Hans Verkuil > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Sylwester Nawrocki Thanks for sticking with it and reworking it many times. Regards, Sylwester