From: Antti Palosaari <crope@iki.fi>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 3/8] Montage M88DS3103 DVB-S/S2 demodulator driver
Date: Sat, 09 Nov 2013 04:48:06 +0200 [thread overview]
Message-ID: <527DA266.2030903@iki.fi> (raw)
In-Reply-To: <CAHFNz9KKajctZphw5bNCoYAyG15Bo+SDWNY=TXR0o337dXyzKA@mail.gmail.com>
On 09.11.2013 04:35, Manu Abraham wrote:
> On Wed, Nov 6, 2013 at 11:27 PM, Antti Palosaari <crope@iki.fi> wrote:
>> +/*
>> + * Driver implements own I2C-adapter for tuner I2C access. That's since chip
>> + * has I2C-gate control which closes gate automatically after I2C transfer.
>> + * Using own I2C adapter we can workaround that.
>> + */
>
>
> Why should the demodulator implement it's own adapter for tuner access ?
In order to implement it properly.
> DS3103 is identical to DS3002, DS3000 which is similar to all other
> dvb demodulators. Comparing datsheets of these demodulators
> with others, I can't see any difference in the repeater setup, except
> for an additional bit field to control the repeater block itself.
>
> Also, from what I see, the vendor; Montage has a driver, which appears
> to be more code complete looking at this url. http://goo.gl/biaPYu
>
> Do you still think the DS3103 is much different in comparison ?
There was even some patches, maybe 2 years, ago in order to mainline
that but it never happened.
More complete is here 53 vs. 86 register writes, so yes it is more ~40
more complete if you like to compare it like that.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-11-09 2:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 17:57 [PATCH 0/8] PCTV DVB-S2 Stick (461e) [2013:0258] driver Antti Palosaari
2013-11-06 17:57 ` [PATCH 1/8] em28xx: add support for Empia EM28178 Antti Palosaari
2013-11-06 17:57 ` [PATCH 2/8] a8293: add small sleep in order to settle LNB voltage Antti Palosaari
2013-11-06 17:57 ` [PATCH 3/8] Montage M88DS3103 DVB-S/S2 demodulator driver Antti Palosaari
2013-11-09 2:35 ` Manu Abraham
2013-11-09 2:48 ` Antti Palosaari [this message]
2013-11-09 3:25 ` Manu Abraham
2013-11-06 17:57 ` [PATCH 4/8] Montage M88TS2022 silicon tuner driver Antti Palosaari
2013-11-06 17:57 ` [PATCH 5/8] em28xx: add support for PCTV DVB-S2 Stick (461e) [2013:0258] Antti Palosaari
2013-11-06 17:57 ` [PATCH 6/8] m88ds3103: add parent for I2C adapter Antti Palosaari
2013-11-06 17:57 ` [PATCH 7/8] MAINTAINERS: add M88DS3103 Antti Palosaari
2013-11-06 17:57 ` [PATCH 8/8] MAINTAINERS: add M88TS2022 Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527DA266.2030903@iki.fi \
--to=crope@iki.fi \
--cc=abraham.manu@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox