Re: [PATCH 1/1] v4l: Add frame end event

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Hans,

Thanks for your comments.

Hans Verkuil wrote:
...
> I have no objections to this patch. You do need to adapt drivers/media/platform/omap3isp/ispccdc.c
> a bit since it is using the FRAME_SYNC event and so it should check the id field.

Good point.

> But will you also be upstreaming a driver that uses the SYNC_END?
>
> I don't really want to merge this if nobody is using it.

I agree --- I can't say right now when there could be an upstreamable 
driver using that event. Let's keep it out of the tree for now.

Especially that after giving some thought to the multi stream use cases 
--- now arguing against my own proposal ;-) --- the "id" field would be 
better used to make a difference between different streams, especially 
for the frame start event. We're not exactly running out of possible 
values for the type field.

So I'd now prefer an entirely separate event to tell about the frame 
end, and perhaps add an alias for the frame sync event (FRAME_START). 
(This again is a proof of why things that are not going to get used 
pretty much immediately should almost never be merged.) I can send a 
patch on that as well, and, should someone else need it, that one can be 
merged, naturally after a review.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com