From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Andy Walls <awalls@md.metrocast.net>,
LMML <linux-media@vger.kernel.org>
Subject: SDR API libv4lconvert remove packet headers in-Kernel or userspace
Date: Thu, 14 Nov 2013 16:04:19 +0200 [thread overview]
Message-ID: <5284D863.1080306@iki.fi> (raw)
Hello
Should I feed whole raw USB packet to libv4lconvert or rip headers off
inside Kernel and feed only data? It is very trivial to remove headers
in kernel and in a case of USB it does not even cost about nothing as
you have to mem copy data out from URB in any case (if you do it on that
phase).
Lets take a most complex case I have. There is not only raw data, but
some meta-data to process samples. In that case those samples are
bit-shifted according to control bits in order to increase nominal
sample resolution from 10 to 12 bits (not sure if it is bit shift or
some other algo, but shifting bits sounds reasonable and testing against
RF-signal generator results looked correct as it is now implemented).
So do I feed that whole USB packet to userspace or do I have to remove
headers + do bit bit shifting and forward only raw samples to userspace?
That example could be found from:
drivers/staging/media/msi3101/sdr-msi3101.c
Here is what on USB packet looks like:
+===============================================================
| 00-1023 | USB packet type '384'
+===============================================================
| 00- 03 | sequence number of first sample in that USB packet
+---------------------------------------------------------------
| 04- 15 | garbage
+---------------------------------------------------------------
| 16- 175 | samples
+---------------------------------------------------------------
| 176- 179 | control bits for previous samples
+---------------------------------------------------------------
| 180- 339 | samples
+---------------------------------------------------------------
| 340- 343 | control bits for previous samples
+---------------------------------------------------------------
| 344- 503 | samples
+---------------------------------------------------------------
| 504- 507 | control bits for previous samples
+---------------------------------------------------------------
| 508- 667 | samples
+---------------------------------------------------------------
| 668- 671 | control bits for previous samples
+---------------------------------------------------------------
| 672- 831 | samples
+---------------------------------------------------------------
| 832- 835 | control bits for previous samples
+---------------------------------------------------------------
| 836- 995 | samples
+---------------------------------------------------------------
| 996- 999 | control bits for previous samples
+---------------------------------------------------------------
| 1000-1023 | garbage
+---------------------------------------------------------------
regards
Antti
--
http://palosaari.fi/
next reply other threads:[~2013-11-14 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 14:04 Antti Palosaari [this message]
2013-11-14 14:16 ` SDR API libv4lconvert remove packet headers in-Kernel or userspace Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284D863.1080306@iki.fi \
--to=crope@iki.fi \
--cc=awalls@md.metrocast.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox