public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: David Howells <dhowells@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-media@vger.kernel.org,
	Jarkko Korpi <jarkko_korpi@hotmail.com>
Subject: Re: I2C transfer logs for Antti's DS3103 driver and DVBSky's DS3103 driver
Date: Fri, 15 Nov 2013 15:54:31 +0200	[thread overview]
Message-ID: <52862797.4070600@iki.fi> (raw)
In-Reply-To: <19084.1384522337@warthog.procyon.org.uk>

On 15.11.2013 15:32, David Howells wrote:
> Antti Palosaari <crope@iki.fi> wrote:
>
>>> demod_write(33, [00])				YES
>>
>> That is config option already. Did you set value? If yes, then there is driver
>> bug. If not, then add value.
>
> But you don't give me the option of _not_ setting it.  The dvbsky driver sets
> it to 0x35 in its init_tab[] - as does yours - and then leaves it alone.

So what? Do you understand meaning of init tables? If you look those 
demod drivers about everyone has init tables and it is used just to set 
some reasonable default values to registers. After that you could change 
those or leave as is, it is just driver logic.

Just set correct value there and it should be OK.
+       .agc = 0x99,


>
>>> 			demod_write(76, [38])	YES
>>
>> on init table
>
> Whilst that may be so, something clears it between one call to
> m88ds3103_set_frontend() and the next, so you probably need to unconditionally
> reload the program init table.

It is programmed conditionally to avoid I/O. Loading logic is simply and 
relies to S/S2/sleep mode change. If there is bug then it should be 
fixed, but I suspect it is just OK as my device is working. If that 
logic is broken then result is likely very dramatic - you will be able 
to view only DVB-S or DVB-S2 channels.

>
>> So hard code those bugs, if you already didn't, 0x33=0x99, 0x56=0x00,
>> 0xfd=0x46 and make test. Do that same to find out all buggy registers until it
>> performs as it should.
>
> I've made my version of your driver now set up the demod regs as per the
> dvbsky driver for:
>
> 	S 11919000 V 27500000 3/4
>
> but:
>
> 	./scan-s2/scan-s2 -a1 ./e.1 >/tmp/s -O S9.0E -D S2
>
> still doesn't work for your driver, despite two goes at tuning.  I guess I
> need to check the tuner writes too.

These bugs sounds more like a demod bugs.


Have you tried simple tune using szap/s2-szap to single channel? Don't 
try scan before it works for single S and S2 channel using zap.

Antti

-- 
http://palosaari.fi/

  parent reply	other threads:[~2013-11-15 13:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 23:35 I2C transfer logs for Antti's DS3103 driver and DVBSky's DS3103 driver David Howells
2013-11-14 23:48 ` Antti Palosaari
2013-11-15  2:15 ` David Howells
2013-11-15 11:33 ` David Howells
2013-11-15 13:06   ` Antti Palosaari
2013-11-15 13:32     ` David Howells
2013-11-15 13:36       ` Devin Heitmueller
2013-11-15 13:54       ` Antti Palosaari [this message]
2013-11-15 14:17         ` David Howells
2013-11-15 13:56       ` David Howells
2013-11-15 13:59         ` Antti Palosaari
2013-11-15 14:25           ` David Howells
2013-11-15 14:01         ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52862797.4070600@iki.fi \
    --to=crope@iki.fi \
    --cc=dhowells@redhat.com \
    --cc=jarkko_korpi@hotmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox