* [PATCH] gspca-stk1135: Add delay after configuring clock
@ 2013-11-03 0:09 Ondrej Zary
2013-11-17 13:41 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Zary @ 2013-11-03 0:09 UTC (permalink / raw)
To: linux-media
Add a small delay at the end of configure_clock() to allow sensor to initialize.
This is needed by Asus VX2S laptop webcam to detect sensor type properly (the already-supported MT9M112).
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/media/usb/gspca/stk1135.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/gspca/stk1135.c b/drivers/media/usb/gspca/stk1135.c
index 8add2f7..d8a813c 100644
--- a/drivers/media/usb/gspca/stk1135.c
+++ b/drivers/media/usb/gspca/stk1135.c
@@ -361,6 +361,9 @@ static void stk1135_configure_clock(struct gspca_dev *gspca_dev)
/* set serial interface clock divider (30MHz/0x1f*16+2) = 60240 kHz) */
reg_w(gspca_dev, STK1135_REG_SICTL + 2, 0x1f);
+
+ /* wait a while for sensor to catch up */
+ udelay(1000);
}
static void stk1135_camera_disable(struct gspca_dev *gspca_dev)
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gspca-stk1135: Add delay after configuring clock
2013-11-03 0:09 [PATCH] gspca-stk1135: Add delay after configuring clock Ondrej Zary
@ 2013-11-17 13:41 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2013-11-17 13:41 UTC (permalink / raw)
To: Ondrej Zary, linux-media
Hi,
On 11/03/2013 01:09 AM, Ondrej Zary wrote:
> Add a small delay at the end of configure_clock() to allow sensor to initialize.
> This is needed by Asus VX2S laptop webcam to detect sensor type properly (the already-supported MT9M112).
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> ---
> drivers/media/usb/gspca/stk1135.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/gspca/stk1135.c b/drivers/media/usb/gspca/stk1135.c
> index 8add2f7..d8a813c 100644
> --- a/drivers/media/usb/gspca/stk1135.c
> +++ b/drivers/media/usb/gspca/stk1135.c
> @@ -361,6 +361,9 @@ static void stk1135_configure_clock(struct gspca_dev *gspca_dev)
>
> /* set serial interface clock divider (30MHz/0x1f*16+2) = 60240 kHz) */
> reg_w(gspca_dev, STK1135_REG_SICTL + 2, 0x1f);
> +
> + /* wait a while for sensor to catch up */
> + udelay(1000);
> }
>
> static void stk1135_camera_disable(struct gspca_dev *gspca_dev)
>
Thanks for the patch. I've added this to my tree for 3.13 .
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-17 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-03 0:09 [PATCH] gspca-stk1135: Add delay after configuring clock Ondrej Zary
2013-11-17 13:41 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).