Re: [PATCH v2 00/16] Add support for Exynox4x12 to the s5p-jpeg driver

[Hans Verkuil <hverkuil@xs4all.nl>]

Hi Jacek,

For this patch series:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

On 11/25/2013 10:58 AM, Jacek Anaszewski wrote:
> This is the second version of the series that adds support for the
> Exynos4x12 device to the s5p_jpeg driver along with accompanying
> fixes. It contains following improvements
> (Hans, Sylwester thanks for the review):
> 
> - moved adjusting chroma subsampling control value from s_ctrl
>   to try_ctrl callback and switched from using v4l2_s_ctrl to
>   v4l2_ctrl_s_ctrl
> - avoided big switch statement in favour of lookup tables
>   for adjusting capture queue fourcc during decoding phase
> - avoided unnecessary displacement of clk_get call in the probe function
> - renamed decoded_subsampling_to_v4l2 to s5p_jpeg_to_user_subsampling
> - added freeing ctrl_handler when v4l2_ctrl_handler_setup fails
> - calling s5p_jpeg_runtime_suspend and s5p_jpeg_runtime_resume
>   only when pm_runtime_suspended returns false
> 
> Thanks,
> Jacek Anaszewski
> 
> Jacek Anaszewski (16):
>   s5p-jpeg: Reorder quantization tables
>   s5p-jpeg: Fix output YUV 4:2:0 fourcc for decoder
>   s5p-jpeg: Fix erroneous condition while validating bytesperline value
>   s5p-jpeg: Remove superfluous call to the jpeg_bound_align_image
>     function
>   s5p-jpeg: Rename functions specific to the S5PC210 SoC accordingly
>   s5p-jpeg: Fix clock resource management
>   s5p-jpeg: Fix lack of spin_lock protection
>   s5p-jpeg: Synchronize cached controls with V4L2 core
>   s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c
>   s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec.
>   s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header
>   s5p-jpeg: Ensure correct capture format for Exynos4x12
>   s5p-jpeg: Allow for wider JPEG subsampling scope for Exynos4x12
>     encoder
>   s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value
>   s5p-jpeg: Ensure setting correct value of the chroma subsampling
>     control
>   s5p-jpeg: Adjust g_volatile_ctrl callback to Exynos4x12 needs
> 
>  drivers/media/platform/s5p-jpeg/Makefile           |    2 +-
>  drivers/media/platform/s5p-jpeg/jpeg-core.c        | 1089 ++++++++++++++++----
>  drivers/media/platform/s5p-jpeg/jpeg-core.h        |   75 +-
>  drivers/media/platform/s5p-jpeg/jpeg-hw-exynos.c   |  293 ++++++
>  drivers/media/platform/s5p-jpeg/jpeg-hw-exynos.h   |   44 +
>  .../platform/s5p-jpeg/{jpeg-hw.h => jpeg-hw-s5p.c} |   82 +-
>  drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.h      |   63 ++
>  drivers/media/platform/s5p-jpeg/jpeg-regs.h        |  215 +++-
>  8 files changed, 1614 insertions(+), 249 deletions(-)
>  create mode 100644 drivers/media/platform/s5p-jpeg/jpeg-hw-exynos.c
>  create mode 100644 drivers/media/platform/s5p-jpeg/jpeg-hw-exynos.h
>  rename drivers/media/platform/s5p-jpeg/{jpeg-hw.h => jpeg-hw-s5p.c} (71%)
>  create mode 100644 drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.h
>