From: Hans Verkuil <hverkuil@xs4all.nl>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH RFC 4/4] v4l: 1 Hz resolution flag for tuners
Date: Thu, 12 Dec 2013 08:55:44 +0100 [thread overview]
Message-ID: <52A96C00.8060607@xs4all.nl> (raw)
In-Reply-To: <1386806043-5331-5-git-send-email-crope@iki.fi>
On 12/12/2013 12:54 AM, Antti Palosaari wrote:
> Add V4L2_TUNER_CAP_1HZ for 1 Hz resolution.
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> include/uapi/linux/videodev2.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 6c6a601..1bac6c4 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1349,6 +1349,7 @@ struct v4l2_modulator {
> #define V4L2_TUNER_CAP_RDS_CONTROLS 0x0200
> #define V4L2_TUNER_CAP_FREQ_BANDS 0x0400
> #define V4L2_TUNER_CAP_HWSEEK_PROG_LIM 0x0800
> +#define V4L2_TUNER_CAP_1HZ 0x1000
>
> /* Flags for the 'rxsubchans' field */
> #define V4L2_TUNER_SUB_MONO 0x0001
>
I was wondering, do the band modulation systems (V4L2_BAND_MODULATION_VSB etc.) cover SDR?
Anyway, I'm happy with this patch series. As far as I am concerned, the next step would
be to add documention and I would also recommend updating v4l2-compliance. Writing docs
and adding compliance tests has proven useful in the past to discover ambiguous API specs.
Regards,
Hans
next prev parent reply other threads:[~2013-12-12 7:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 23:53 [PATCH RFC 0/4] SDR API set ADC and RF frequency Antti Palosaari
2013-12-11 23:54 ` [PATCH RFC 1/4] v4l2-core: don't clear VIDIOC_G_FREQUENCY tuner type Antti Palosaari
2013-12-11 23:54 ` [PATCH RFC 2/4] v4l2: add new device type for Software Defined Radio Antti Palosaari
2013-12-11 23:54 ` [PATCH RFC 3/4] v4l: add new tuner types for SDR Antti Palosaari
2013-12-12 7:50 ` Hans Verkuil
2013-12-12 17:12 ` Antti Palosaari
2013-12-12 19:14 ` Antti Palosaari
2013-12-13 14:31 ` Hans Verkuil
2013-12-13 13:58 ` Hans Verkuil
2013-12-11 23:54 ` [PATCH RFC 4/4] v4l: 1 Hz resolution flag for tuners Antti Palosaari
2013-12-12 7:55 ` Hans Verkuil [this message]
2013-12-12 17:22 ` Antti Palosaari
2013-12-13 14:05 ` Hans Verkuil
2013-12-13 15:42 ` Antti Palosaari
2013-12-13 16:08 ` Hans Verkuil
2013-12-13 19:27 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A96C00.8060607@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox