From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:48444 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513Ab3LLPcX (ORCPT ); Thu, 12 Dec 2013 10:32:23 -0500 Message-id: <52A9D6FE.30302@samsung.com> Date: Thu, 12 Dec 2013 16:32:14 +0100 From: Sylwester Nawrocki MIME-version: 1.0 To: Arun Kumar K , linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Cc: shaik.ameer@samsung.com, arunkk.samsung@gmail.com, Mark Rutland , Mauro Carvalho Chehab Subject: Re: [PATCH v11 1/2] [media] exynos5-is: Adds DT binding documentation References: <1383650355-28838-1-git-send-email-arun.kk@samsung.com> In-reply-to: <1383650355-28838-1-git-send-email-arun.kk@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Arun, (Adding Mark and Mauro to Cc) On 05/11/13 12:19, Arun Kumar K wrote: > From: Shaik Ameer Basha > > The patch adds the DT binding doc for exynos5 SoC camera > subsystem. > > Signed-off-by: Shaik Ameer Basha > Signed-off-by: Arun Kumar K > --- > .../bindings/media/exynos5250-camera.txt | 126 ++++++++++++++++++++ > 1 file changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/exynos5250-camera.txt > > diff --git a/Documentation/devicetree/bindings/media/exynos5250-camera.txt b/Documentation/devicetree/bindings/media/exynos5250-camera.txt > new file mode 100644 > index 0000000..09420ba > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/exynos5250-camera.txt > @@ -0,0 +1,126 @@ > +Samsung EXYNOS5 SoC Camera Subsystem > +------------------------------------ > + > +The Exynos5 SoC Camera subsystem comprises of multiple sub-devices > +represented by separate device tree nodes. Currently this includes: FIMC-LITE, > +MIPI CSIS and FIMC-IS. > + > +The sub-device nodes are referenced using phandles in the common 'camera' node > +which also includes common properties of the whole subsystem not really > +specific to any single sub-device, like common camera port pins or the common > +camera bus clocks. > + > +Common 'camera' node > +-------------------- > + > +Required properties: > + > +- compatible : must be "samsung,exynos5250-fimc" > +- clocks : list of clock specifiers, corresponding to entries in > + the clock-names property > +- clock-names : must contain "sclk_bayer" entry > +- samsung,csis : list of phandles to the mipi-csis device nodes > +- samsung,fimc-lite : list of phandles to the fimc-lite device nodes > +- samsung,fimc-is : phandle to the fimc-is device node > + > +The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used > +to define a required pinctrl state named "default". > + > +'parallel-ports' node > +--------------------- > + > +This node should contain child 'port' nodes specifying active parallel video > +input ports. It includes camera A, camera B and RGB bay inputs. > +'reg' property in the port nodes specifies the input type: > + 1 - parallel camport A > + 2 - parallel camport B > + 5 - RGB camera bay > + > +3, 4 are for MIPI CSI-2 bus and are already described in samsung-mipi-csis.txt Was there posted a version of this patch with Mark's comments addressed: http://www.spinics.net/lists/devicetree/msg11550.html ? I couldn't find it. -- Thanks, Sylwester