From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: 3fdfedaaa7f243f3347084231c64f6c1be0ba131 causes a regression
Date: Tue, 17 Dec 2013 11:42:02 +0100 [thread overview]
Message-ID: <52B02A7A.4010901@epfl.ch> (raw)
Hello Laurent,
I was working on having a functional IOMMU/ISP for 3.14, and had an
issue with an image completely distorted. Comparing with another kernel,
I saw that PRV_HORZ_INFO and PRV_VERT_INFO differed. On the newer
kernel, sph, eph, svl, and slv were all off-by 2, causing my final image
to miss 4 pixels on each line, thus distorting the result.
Your commit 3fdfedaaa7f243f3347084231c64f6c1be0ba131 '[media] omap3isp:
preview: Lower the crop margins' indeed changes PRV_HORZ_INFO and
PRV_VERT_INFO by removing the if() condition. Reverting it made my image
to be valid again.
FYI, my pipeline is:
MT9V032 (SGRBG10 752x480) -> CCDC -> PREVIEW (UYVY 752x480) -> RESIZER
-> out
Regards,
Florian
next reply other threads:[~2013-12-17 10:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 10:42 Florian Vaussard [this message]
2013-12-23 21:47 ` Regression inside omap3isp/resizer (was: 3fdfeda causes a regression) Florian Vaussard
2013-12-31 8:51 ` Laurent Pinchart
2014-01-09 18:09 ` Regression inside omap3isp/resizer Florian Vaussard
2014-01-09 20:34 ` Laurent Pinchart
2014-01-09 20:45 ` Florian Vaussard
2014-01-09 20:50 ` Laurent Pinchart
2014-01-17 7:15 ` Sakari Ailus
2014-01-17 14:45 ` Florian Vaussard
2014-01-17 18:15 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B02A7A.4010901@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).