public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Martin Bugge <marbugge@cisco.com>, Hans Verkuil <hans.verkuil@cisco.com>
Subject: [RFC PATCH 23/22] adv7842: return 0 if no change in s_dv_timings
Date: Tue, 17 Dec 2013 14:16:53 +0100	[thread overview]
Message-ID: <52B04EC5.5080303@xs4all.nl> (raw)
In-Reply-To: <9e9eaa702db4b0e0626dbf7200578e66d8281312.1386687810.git.hans.verkuil@cisco.com>

Return 0 if the new timings are equal to the current timings as
it caused extra cp-loss/lock interrupts.

Signed-off-by: Martin Bugge <marbugge@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
 drivers/media/i2c/adv7842.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c
index bafe3b5..82c57d7 100644
--- a/drivers/media/i2c/adv7842.c
+++ b/drivers/media/i2c/adv7842.c
@@ -1453,6 +1453,11 @@ static int adv7842_s_dv_timings(struct v4l2_subdev *sd,
 	if (state->mode == ADV7842_MODE_SDP)
 		return -ENODATA;
 
+	if (v4l2_match_dv_timings(&state->timings, timings, 0)) {
+		v4l2_dbg(1, debug, sd, "%s: no change\n", __func__);
+		return 0;
+	}
+
 	bt = &timings->bt;
 
 	if (!v4l2_valid_dv_timings(timings, adv7842_get_dv_timings_cap(sd),
-- 
1.8.4.rc3



  reply	other threads:[~2013-12-17 13:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 15:03 [RFC PATCH 00/22] adv7842: fixes Hans Verkuil
2013-12-10 15:03 ` [RFC PATCH 01/22] adv7842: Re-worked query_dv_timings() Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 02/22] adv7842: corrected setting of cp-register 0x91 and 0x8f Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 03/22] adv7842: properly enable/disable the irqs Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 04/22] adv7842: save platform data in state struct Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 05/22] adv7842: support YCrCb analog input Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 06/22] adv7842: added DE vertical position in SDP-io-sync Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 07/22] adv7842: Receive CEA formats as RGB on VGA (RGB) input Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 08/22] adv7842: set defaults spa-location Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 09/22] adv7842: 625/525 line standard jitter fix Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 10/22] adv7842: set default input in platform-data Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 11/22] adv7842: increase wait time Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 12/22] adv7842: remove connector type. Never used for anything useful Hans Verkuil
2013-12-10 15:03   ` [RFC PATCH 13/22] adv7842: Use defines to select EDID port Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 14/22] adv7842: mute audio before switching inputs to avoid noise/pops Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 15/22] adv7842: clear edid, if no edid just disable Edid-DDC access Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 16/22] adv7842: restart STDI once if format is not found Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 17/22] adv7842: support g_edid ioctl Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 18/22] adv7842: i2c dummy clients registration Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 19/22] adv7842: enable HDMI/DVI mode irq Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 20/22] adv7842: composite sd-ram test, clear timings before setting Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 21/22] adv7842: obtain free-run mode from the platform_data Hans Verkuil
2013-12-10 15:04   ` [RFC PATCH 22/22] adv7842: Composite sync adjustment Hans Verkuil
2013-12-17 13:16     ` Hans Verkuil [this message]
2013-12-17 13:17     ` [RFC PATCH 24/22] adv7842: set LLC DLL phase from platform_data Hans Verkuil
2013-12-17 20:59       ` Antti Palosaari
2013-12-17 13:17     ` [RFC PATCH 25/22] adv7842: initialize timings to CEA 640x480p59.94 Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B04EC5.5080303@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    --cc=marbugge@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox