From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH RFC v3 5/7] v4l: enable some IOCTLs for SDR receiver
Date: Tue, 17 Dec 2013 18:40:38 +0200 [thread overview]
Message-ID: <52B07E86.1030100@iki.fi> (raw)
In-Reply-To: <52AFFEA3.7010200@xs4all.nl>
On 17.12.2013 09:34, Hans Verkuil wrote:
> On 12/16/2013 11:08 PM, Antti Palosaari wrote:
>> + } else if (is_sdr) {
>> +
>> + if (is_rx) {
>> + SET_VALID_IOCTL(ops, VIDIOC_ENUMINPUT, vidioc_enum_input);
>> + SET_VALID_IOCTL(ops, VIDIOC_G_INPUT, vidioc_g_input);
>> + SET_VALID_IOCTL(ops, VIDIOC_S_INPUT, vidioc_s_input);
>
> Why would you want to enable these? Normal radio devices should never use
> these, so why would sdr devices?
I though it might be good idea to select possible antenna input. I have
one rtl2832u prototype which has 2 physical antenna connector, but on
the real life input selection is not needed even on that case as
antennas are hardwired to different tuner inputs => selection is done
according to frequency. Almost all modern silicon tuners has multiple
inputs, whilst device has only one physical antenna connector.
All-in-all, it is not needed now and I can remove it without any noise
if you wish. It is trivial to add later if really needed.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-12-17 16:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 22:08 [PATCH RFC v3 0/7] SDR API Antti Palosaari
2013-12-16 22:08 ` [PATCH RFC v3 1/7] v4l: add new tuner types for SDR Antti Palosaari
2013-12-17 7:31 ` Hans Verkuil
2013-12-16 22:08 ` [PATCH RFC v3 2/7] v4l: 1 Hz resolution flag for tuners Antti Palosaari
2013-12-17 7:31 ` Hans Verkuil
2013-12-16 22:08 ` [PATCH RFC v3 3/7] v4l: add stream format for SDR receiver Antti Palosaari
2013-12-17 7:32 ` Hans Verkuil
2013-12-16 22:08 ` [PATCH RFC v3 4/7] v4l: define own IOCTL ops for SDR FMT Antti Palosaari
2013-12-17 7:32 ` Hans Verkuil
2013-12-16 22:08 ` [PATCH RFC v3 5/7] v4l: enable some IOCTLs for SDR receiver Antti Palosaari
2013-12-17 7:34 ` Hans Verkuil
2013-12-17 16:40 ` Antti Palosaari [this message]
2013-12-18 7:32 ` Hans Verkuil
2013-12-16 22:08 ` [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API Antti Palosaari
2013-12-17 7:45 ` Hans Verkuil
2013-12-19 9:21 ` Hans Verkuil
2013-12-19 16:50 ` Antti Palosaari
2013-12-19 16:59 ` Devin Heitmueller
2013-12-19 18:38 ` Antti Palosaari
2013-12-19 19:12 ` Devin Heitmueller
2013-12-16 22:08 ` [PATCH RFC v3 7/7] msi3101: " Antti Palosaari
2013-12-17 7:36 ` [PATCH RFC v3 0/7] " Hans Verkuil
2013-12-17 16:46 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B07E86.1030100@iki.fi \
--to=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox