From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:36821 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753625Ab3LQQkl (ORCPT ); Tue, 17 Dec 2013 11:40:41 -0500 Message-ID: <52B07E86.1030100@iki.fi> Date: Tue, 17 Dec 2013 18:40:38 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Hans Verkuil CC: linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH RFC v3 5/7] v4l: enable some IOCTLs for SDR receiver References: <1387231688-8647-1-git-send-email-crope@iki.fi> <1387231688-8647-6-git-send-email-crope@iki.fi> <52AFFEA3.7010200@xs4all.nl> In-Reply-To: <52AFFEA3.7010200@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 17.12.2013 09:34, Hans Verkuil wrote: > On 12/16/2013 11:08 PM, Antti Palosaari wrote: >> + } else if (is_sdr) { >> + >> + if (is_rx) { >> + SET_VALID_IOCTL(ops, VIDIOC_ENUMINPUT, vidioc_enum_input); >> + SET_VALID_IOCTL(ops, VIDIOC_G_INPUT, vidioc_g_input); >> + SET_VALID_IOCTL(ops, VIDIOC_S_INPUT, vidioc_s_input); > > Why would you want to enable these? Normal radio devices should never use > these, so why would sdr devices? I though it might be good idea to select possible antenna input. I have one rtl2832u prototype which has 2 physical antenna connector, but on the real life input selection is not needed even on that case as antennas are hardwired to different tuner inputs => selection is done according to frequency. Almost all modern silicon tuners has multiple inputs, whilst device has only one physical antenna connector. All-in-all, it is not needed now and I can remove it without any noise if you wish. It is trivial to add later if really needed. regards Antti -- http://palosaari.fi/