From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ea0-f181.google.com ([209.85.215.181]:37164 "EHLO mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171AbaAMSuO (ORCPT ); Mon, 13 Jan 2014 13:50:14 -0500 Received: by mail-ea0-f181.google.com with SMTP id m10so3496346eaj.26 for ; Mon, 13 Jan 2014 10:50:12 -0800 (PST) Message-ID: <52D435AC.5030306@googlemail.com> Date: Mon, 13 Jan 2014 19:51:24 +0100 From: =?ISO-8859-1?Q?Frank_Sch=E4fer?= MIME-Version: 1.0 To: Mauro Carvalho Chehab , unlisted-recipients:; CC: Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCH 6/7] em28xx: print a message at disconnect References: <1389567649-26838-1-git-send-email-m.chehab@samsung.com> <1389567649-26838-7-git-send-email-m.chehab@samsung.com> In-Reply-To: <1389567649-26838-7-git-send-email-m.chehab@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On 13.01.2014 00:00, Mauro Carvalho Chehab wrote: > That helps to identify if something fails and explain why em28xx > struct is not freed (if it ever happens). > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/usb/em28xx/em28xx-audio.c | 2 ++ > drivers/media/usb/em28xx/em28xx-dvb.c | 2 ++ > drivers/media/usb/em28xx/em28xx-input.c | 2 ++ > drivers/media/usb/em28xx/em28xx-video.c | 2 ++ > 4 files changed, 8 insertions(+) > > diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c > index 5e16fcf18cac..0ec4742c3ab0 100644 > --- a/drivers/media/usb/em28xx/em28xx-audio.c > +++ b/drivers/media/usb/em28xx/em28xx-audio.c > @@ -962,6 +962,8 @@ static int em28xx_audio_fini(struct em28xx *dev) > return 0; > } > > + em28xx_info("Disconnecting audio extension"); > + > snd_card_disconnect(dev->adev.sndcard); > em28xx_audio_free_urb(dev); > > diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c > index 8674ae5fce06..7ba209de57dd 100644 > --- a/drivers/media/usb/em28xx/em28xx-dvb.c > +++ b/drivers/media/usb/em28xx/em28xx-dvb.c > @@ -1473,6 +1473,8 @@ static int em28xx_dvb_fini(struct em28xx *dev) > return 0; > } > > + em28xx_info("Disconnecting DVB extension"); > + > if (dev->dvb) { > struct em28xx_dvb *dvb = dev->dvb; > > diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c > index 33388b5922a0..bf04c5e1bd2a 100644 > --- a/drivers/media/usb/em28xx/em28xx-input.c > +++ b/drivers/media/usb/em28xx/em28xx-input.c > @@ -812,6 +812,8 @@ static int em28xx_ir_fini(struct em28xx *dev) > return 0; > } > > + em28xx_info("Disconnecting input extension"); > + > em28xx_shutdown_buttons(dev); > > /* skip detach on non attached boards */ > diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c > index dc10cec772ba..004fe12ceec7 100644 > --- a/drivers/media/usb/em28xx/em28xx-video.c > +++ b/drivers/media/usb/em28xx/em28xx-video.c > @@ -1894,6 +1894,8 @@ static int em28xx_v4l2_fini(struct em28xx *dev) > return 0; > } > > + em28xx_info("Disconnecting video extension"); > + > v4l2_device_disconnect(&dev->v4l2_dev); > > em28xx_uninit_usb_xfer(dev, EM28XX_ANALOG_MODE); I would say "Closing" instead of "Disconnecting". That's also how we call the function that calls the extensions fini() methods. Reviewed-by: Frank Schäfer