From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:54905 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082AbaAaQHC (ORCPT ); Fri, 31 Jan 2014 11:07:02 -0500 Message-ID: <52EBC9EA.1000809@linux.intel.com> Date: Fri, 31 Jan 2014 18:06:02 +0200 From: Sakari Ailus MIME-Version: 1.0 To: Hans Verkuil CC: linux-media@vger.kernel.org Subject: Re: [PATCH 1/1] v4l: subdev: Allow 32-bit compat IOCTLs References: <1391182129-5234-1-git-send-email-sakari.ailus@linux.intel.com> <52EBC33C.6050902@xs4all.nl> <52EBC693.6040709@linux.intel.com> In-Reply-To: <52EBC693.6040709@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Sakari Ailus wrote: > Hi Hans, > > Thanks for the comments. > > Hans Verkuil wrote: >> Hi Sakari, >> >> Sorry, this isn't right. >> >> It should go through v4l2_compat_ioctl32, otherwise ioctls for e.g. >> extended controls >> won't be converted correctly. > > Now that you mention it, indeed the state back when I thought this was > already implemented, the IOCTLs were exactly the same. Now that struct > v4l2_subdev_edid is used on VIDIOC_SUBDEV_G_EDID and > VIDIOC_SUBDEV_S_EDID32, this no longer holds. Well, indeed, with the patch, the compat_ioctl32 handler wrongly would handle the non-compat IOCTL as well. To fix this properly, the sub-device IOCTL numbers that require no conversion should be added to v4l2_compat_ioctl32() list of IOCTLs. Currently they're not there. Is this what you meant? -- Regards, Sakari Ailus sakari.ailus@linux.intel.com