Re: [PATCH] s2255drv: file handle cleanup

[Hans Verkuil <hverkuil@xs4all.nl>]

On 02/05/2014 12:10 AM, Dean Anderson wrote:
> Hi Hans,
> 
> Please ignore and reject this patch. videobuf_queue_vmalloc_init needs 
> to be in probe, not in open.
> 
> Let me know your thoughts on doing videobuf2 before s2255_fh removal so 
> we don't have to work around or fix videobuf version one's deficiencies.

What I have done in the past w.r.t. vb2 conversions is to move fields
out of the fh struct where it is possible without breaking videobuf, then
when I do the final vb2 conversion I drop the fh struct completely.

As you mentioned before, the resources field can't really be dropped
until the vb2 conversion, but it simplifies matters if the rest is moved
out first. The end result of a vb2 conversion is great, but the actual
patch is a pain to review :-)

Now that I am adding streaming tests in v4l2-compliance I am hoping that
it will be easier to verify correctness in the future, something that
really hasn't been possible.

Regards,

	Hans

> 
> Thanks,
> 
> 
> 
> 
> On 2014-02-04 16:36, Dean Anderson wrote:
>> Removes most parameters from s2255_fh.  These elements belong in 
>> s2255_ch.
>> In the future, s2255_fh will be removed when videobuf2 is used. 
>> videobuf2
>> has convenient and safe functions for locking streaming resources.
>>
>> The removal of s2255_fh (and s2255_fh->resources) was not done now to
>> avoid using videobuf_queue_is_busy.
>>
>> videobuf_queue_is busy may be unsafe as noted by the following comment
>> in videobuf-core.c:
>> "/* Locking: Only usage in bttv unsafe find way to remove */"
>>
>> Signed-off-by: Dean Anderson <linux-dev@sensoray.com>
>> ---