From: James Hogan <james.hogan@imgtec.com>
To: "Antti Seppälä" <a.seppala@gmail.com>,
"Mauro Carvalho Chehab" <m.chehab@samsung.com>
Cc: Sean Young <sean@mess.org>, <linux-media@vger.kernel.org>
Subject: Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes
Date: Wed, 5 Feb 2014 09:39:33 +0000 [thread overview]
Message-ID: <52F206D5.9060601@imgtec.com> (raw)
In-Reply-To: <CAKv9HNbYJ5FsQas=03u8pXCyiF5VSUfsOR46McukeisqVHme+g@mail.gmail.com>
Hi Antti,
On 05/02/14 07:03, Antti Seppälä wrote:
> To wake up with nuvoton-cir we need to program several raw ir
> pulse/space lengths to the hardware and not a scancode. James's
> approach doesn't support this.
Do the raw pulse/space lengths your hardware requires correspond to a
single IR packet (mapping to a single scancode)?
If so then my API is simply at a higher level of abstraction. I think
this has the following advantages:
* userspace sees a consistent interface at the same level of abstraction
as it already has access to from input subsystem (i.e. scancodes). I.e.
it doesn't need to care which IR device is in use, whether it does
raw/hardware decode, or the details of the timings of the current protocol.
* it supports hardware decoders which filter on the demodulated data
rather than the raw pulse/space lengths.
Of course to support this we'd need some per-protocol code to convert a
scancode back to pulse/space lengths. I'd like to think that code could
be generic, maybe as helper functions which multiple drivers could use,
which could also handle corner cases of the API in a consistent way
(e.g. user providing filter mask covering multiple scancodes, which
presumably pulse/space).
I see I've just crossed emails with Mauro who has just suggested
something similar. I agree that his (2) is the more elegant option.
Cheers
James
next prev parent reply other threads:[~2014-02-05 9:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 14:18 [PATCH] nuvoton-cir: Add support for user configurable wake-up codes Antti Seppälä
2014-01-15 19:35 ` Mauro Carvalho Chehab
2014-01-20 19:39 ` [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes Antti Seppälä
2014-01-20 19:39 ` [RFC PATCH 1/4] rc-core: Add defintions needed for sysfs callback Antti Seppälä
2014-01-20 19:39 ` [RFC PATCH 2/4] rc-core: Add support for reading/writing wakeup scancodes via sysfs Antti Seppälä
2014-01-20 19:39 ` [RFC PATCH 3/4] rc-loopback: " Antti Seppälä
2014-01-20 19:39 ` [RFC PATCH 4/4] nuvoton-cir: " Antti Seppälä
2014-01-21 12:28 ` [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes Sean Young
2014-01-22 15:46 ` Antti Seppälä
2014-01-22 16:29 ` Sean Young
2014-01-22 19:10 ` Antti Seppälä
2014-01-22 19:21 ` Antti Palosaari
2014-01-22 21:00 ` Sean Young
2014-01-22 22:01 ` Mauro Carvalho Chehab
2014-01-23 19:11 ` Antti Seppälä
2014-02-04 17:54 ` Mauro Carvalho Chehab
2014-02-05 7:03 ` Antti Seppälä
2014-02-05 9:36 ` Mauro Carvalho Chehab
2014-02-05 9:39 ` James Hogan [this message]
2014-02-05 9:42 ` James Hogan
2014-02-05 18:16 ` Antti Seppälä
2014-02-05 21:21 ` Mauro Carvalho Chehab
2014-02-06 10:46 ` James Hogan
2014-02-06 14:55 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F206D5.9060601@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=a.seppala@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox