From: Hans Verkuil <hverkuil@xs4all.nl>
To: Richard Weinberger <richard@nod.at>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
"open list:MEDIA INPUT INFRA..." <linux-media@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH 19/28] Remove SI4713
Date: Sun, 09 Feb 2014 20:13:39 +0100 [thread overview]
Message-ID: <52F7D363.2080108@xs4all.nl> (raw)
In-Reply-To: <1391971686-9517-20-git-send-email-richard@nod.at>
On 02/09/2014 07:47 PM, Richard Weinberger wrote:
> The symbol is an orphan, get rid of it.
NACK.
It's not an orphan, it's a typo. It should be I2C_SI4713.
Paul, Richard, let me handle this. I'll make a patch for this tomorrow (I believe
there was a report about a missing I2C dependency as well) and make sure it ends
up in a pull request for 3.14.
Regards,
Hans
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/media/radio/si4713/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
> index a7c3ba8..ed51ed0 100644
> --- a/drivers/media/radio/si4713/Kconfig
> +++ b/drivers/media/radio/si4713/Kconfig
> @@ -1,7 +1,6 @@
> config USB_SI4713
> tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
> depends on USB && RADIO_SI4713
> - select SI4713
> ---help---
> This is a driver for USB devices with the Silicon Labs SI4713
> chip. Currently these devices are known to work.
> @@ -16,7 +15,6 @@ config USB_SI4713
> config PLATFORM_SI4713
> tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
> depends on I2C && RADIO_SI4713
> - select SI4713
> ---help---
> This is a driver for I2C devices with the Silicon Labs SI4713
> chip.
>
next prev parent reply other threads:[~2014-02-09 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391971686-9517-1-git-send-email-richard@nod.at>
2014-02-09 18:47 ` [PATCH 19/28] Remove SI4713 Richard Weinberger
2014-02-09 19:13 ` Hans Verkuil [this message]
2014-02-09 20:03 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F7D363.2080108@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pebolle@tiscali.nl \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox