public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 19/28] Remove SI4713
       [not found] <1391971686-9517-1-git-send-email-richard@nod.at>
@ 2014-02-09 18:47 ` Richard Weinberger
  2014-02-09 19:13   ` Hans Verkuil
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2014-02-09 18:47 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, open list:MEDIA INPUT INFRA..., open list
  Cc: Richard Weinberger

The symbol is an orphan, get rid of it.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/media/radio/si4713/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
index a7c3ba8..ed51ed0 100644
--- a/drivers/media/radio/si4713/Kconfig
+++ b/drivers/media/radio/si4713/Kconfig
@@ -1,7 +1,6 @@
 config USB_SI4713
 	tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
 	depends on USB && RADIO_SI4713
-	select SI4713
 	---help---
 	  This is a driver for USB devices with the Silicon Labs SI4713
 	  chip. Currently these devices are known to work.
@@ -16,7 +15,6 @@ config USB_SI4713
 config PLATFORM_SI4713
 	tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
 	depends on I2C && RADIO_SI4713
-	select SI4713
 	---help---
 	  This is a driver for I2C devices with the Silicon Labs SI4713
 	  chip.
-- 
1.8.4.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 19/28] Remove SI4713
  2014-02-09 18:47 ` [PATCH 19/28] Remove SI4713 Richard Weinberger
@ 2014-02-09 19:13   ` Hans Verkuil
  2014-02-09 20:03     ` Richard Weinberger
  0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2014-02-09 19:13 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: Mauro Carvalho Chehab, open list:MEDIA INPUT INFRA..., open list,
	Paul Bolle

On 02/09/2014 07:47 PM, Richard Weinberger wrote:
> The symbol is an orphan, get rid of it.

NACK.

It's not an orphan, it's a typo. It should be I2C_SI4713.

Paul, Richard, let me handle this. I'll make a patch for this tomorrow (I believe
there was a report about a missing I2C dependency as well) and make sure it ends
up in a pull request for 3.14.

Regards,

	Hans

> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  drivers/media/radio/si4713/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
> index a7c3ba8..ed51ed0 100644
> --- a/drivers/media/radio/si4713/Kconfig
> +++ b/drivers/media/radio/si4713/Kconfig
> @@ -1,7 +1,6 @@
>  config USB_SI4713
>  	tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
>  	depends on USB && RADIO_SI4713
> -	select SI4713
>  	---help---
>  	  This is a driver for USB devices with the Silicon Labs SI4713
>  	  chip. Currently these devices are known to work.
> @@ -16,7 +15,6 @@ config USB_SI4713
>  config PLATFORM_SI4713
>  	tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
>  	depends on I2C && RADIO_SI4713
> -	select SI4713
>  	---help---
>  	  This is a driver for I2C devices with the Silicon Labs SI4713
>  	  chip.
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 19/28] Remove SI4713
  2014-02-09 19:13   ` Hans Verkuil
@ 2014-02-09 20:03     ` Richard Weinberger
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2014-02-09 20:03 UTC (permalink / raw)
  To: Hans Verkuil
  Cc: Mauro Carvalho Chehab, open list:MEDIA INPUT INFRA..., open list,
	Paul Bolle



Am 09.02.2014 20:13, schrieb Hans Verkuil:
> On 02/09/2014 07:47 PM, Richard Weinberger wrote:
>> The symbol is an orphan, get rid of it.
> 
> NACK.
> 
> It's not an orphan, it's a typo. It should be I2C_SI4713.
> 
> Paul, Richard, let me handle this. I'll make a patch for this tomorrow (I believe
> there was a report about a missing I2C dependency as well) and make sure it ends
> up in a pull request for 3.14.

This is perfectly fine. Thanks for sorting this out!

Thanks,
//richard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-09 20:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1391971686-9517-1-git-send-email-richard@nod.at>
2014-02-09 18:47 ` [PATCH 19/28] Remove SI4713 Richard Weinberger
2014-02-09 19:13   ` Hans Verkuil
2014-02-09 20:03     ` Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox