Re: [REVIEW PATCH 3/6] v4l: reorganize RF tuner control ID numbers

[Hans Verkuil <hverkuil@xs4all.nl>]

On 02/14/2014 03:36 PM, Antti Palosaari wrote:
> On 14.02.2014 16:20, Hans Verkuil wrote:
>> Hi Antti,
>>
>> On 02/10/2014 05:17 PM, Antti Palosaari wrote:
>>> It appears that controls are ordered by ID number. Change order of
>>> controls by reorganizing assigned IDs now as we can. It is not
>>> reasonable possible after the API is released. Leave some spare
>>> space between IDs too for future extensions.
>>
>> Am I missing something? I see no reason for this patch or for adding the
>> spare space.
> 
> "It appears that controls are ordered by ID number"
> 
> I used app called v4l2ucp and at least it seems to organize those 
> controls by ID. Is there some way to say application how those are 
> organized?

Ah, now I get it. When enumerating controls they are enumerated by
increasing control ID. Yes, that's correct.

The commit message could be improved since I completely missed the point :-)

Regards,

	Hans

> 
> regards
> Antti
> 
> 
>>
>> Regards,
>>
>> 	Hans
>>
>>>
>>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>>> ---
>>>   include/uapi/linux/v4l2-controls.h | 16 ++++++++--------
>>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
>>> index 3cf68a6..cc488c3 100644
>>> --- a/include/uapi/linux/v4l2-controls.h
>>> +++ b/include/uapi/linux/v4l2-controls.h
>>> @@ -899,13 +899,13 @@ enum v4l2_deemphasis {
>>>   #define V4L2_CID_RF_TUNER_CLASS_BASE		(V4L2_CTRL_CLASS_RF_TUNER | 0x900)
>>>   #define V4L2_CID_RF_TUNER_CLASS			(V4L2_CTRL_CLASS_RF_TUNER | 1)
>>>
>>> -#define V4L2_CID_LNA_GAIN_AUTO			(V4L2_CID_RF_TUNER_CLASS_BASE + 1)
>>> -#define V4L2_CID_LNA_GAIN			(V4L2_CID_RF_TUNER_CLASS_BASE + 2)
>>> -#define V4L2_CID_MIXER_GAIN_AUTO		(V4L2_CID_RF_TUNER_CLASS_BASE + 3)
>>> -#define V4L2_CID_MIXER_GAIN			(V4L2_CID_RF_TUNER_CLASS_BASE + 4)
>>> -#define V4L2_CID_IF_GAIN_AUTO			(V4L2_CID_RF_TUNER_CLASS_BASE + 5)
>>> -#define V4L2_CID_IF_GAIN			(V4L2_CID_RF_TUNER_CLASS_BASE + 6)
>>> -#define V4L2_CID_BANDWIDTH_AUTO			(V4L2_CID_RF_TUNER_CLASS_BASE + 7)
>>> -#define V4L2_CID_BANDWIDTH			(V4L2_CID_RF_TUNER_CLASS_BASE + 8)
>>> +#define V4L2_CID_BANDWIDTH_AUTO			(V4L2_CID_RF_TUNER_CLASS_BASE + 11)
>>> +#define V4L2_CID_BANDWIDTH			(V4L2_CID_RF_TUNER_CLASS_BASE + 12)
>>> +#define V4L2_CID_LNA_GAIN_AUTO			(V4L2_CID_RF_TUNER_CLASS_BASE + 41)
>>> +#define V4L2_CID_LNA_GAIN			(V4L2_CID_RF_TUNER_CLASS_BASE + 42)
>>> +#define V4L2_CID_MIXER_GAIN_AUTO		(V4L2_CID_RF_TUNER_CLASS_BASE + 51)
>>> +#define V4L2_CID_MIXER_GAIN			(V4L2_CID_RF_TUNER_CLASS_BASE + 52)
>>> +#define V4L2_CID_IF_GAIN_AUTO			(V4L2_CID_RF_TUNER_CLASS_BASE + 61)
>>> +#define V4L2_CID_IF_GAIN			(V4L2_CID_RF_TUNER_CLASS_BASE + 62)
>>>
>>>   #endif
>>>
>>
> 
>