From: Hans Verkuil <hverkuil@xs4all.nl>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Michael Krufky <mkrufky@linuxtv.org>,
Cong Ding <dinggnu@gmail.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] stv0900: remove an unneeded check
Date: Thu, 20 Feb 2014 11:24:58 +0100 [thread overview]
Message-ID: <5305D7FA.9090402@xs4all.nl> (raw)
In-Reply-To: <20140206092402.GA31780@elgon.mountain>
On 02/06/14 10:24, Dan Carpenter wrote:
> No need to check "lock" twice here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
>
> diff --git a/drivers/media/dvb-frontends/stv0900_sw.c b/drivers/media/dvb-frontends/stv0900_sw.c
> index 0a40edfad739..4ce1d260b3eb 100644
> --- a/drivers/media/dvb-frontends/stv0900_sw.c
> +++ b/drivers/media/dvb-frontends/stv0900_sw.c
> @@ -1081,7 +1081,7 @@ static int stv0900_wait_for_lock(struct stv0900_internal *intp,
> lock = stv0900_get_demod_lock(intp, demod, dmd_timeout);
>
> if (lock)
> - lock = lock && stv0900_get_fec_lock(intp, demod, fec_timeout);
> + lock = stv0900_get_fec_lock(intp, demod, fec_timeout);
>
> if (lock) {
> lock = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-02-20 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 9:24 [patch] [media] stv0900: remove an unneeded check Dan Carpenter
2014-02-20 10:24 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5305D7FA.9090402@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dan.carpenter@oracle.com \
--cc=dinggnu@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox