From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:40490 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753331AbaBUJ54 (ORCPT ); Fri, 21 Feb 2014 04:57:56 -0500 Message-ID: <53072326.7050809@iki.fi> Date: Fri, 21 Feb 2014 11:57:58 +0200 From: Sakari Ailus MIME-Version: 1.0 To: Daniel Jeong , Mauro Carvalho Chehab , Rob Landley , Andy Shevchenko CC: Hans Verkuil , linux-media@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC v5,2/3] controls.xml : add addtional Flash fault bits References: <1392958166-4614-1-git-send-email-gshark.jeong@gmail.com> In-Reply-To: <1392958166-4614-1-git-send-email-gshark.jeong@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Daniel, Daniel Jeong wrote: > Added more comment about Input voltage flash monitor and external temp function. > > Signed-off-by: Daniel Jeong > --- > Documentation/DocBook/media/v4l/controls.xml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml > index a5a3188..145a127 100644 > --- a/Documentation/DocBook/media/v4l/controls.xml > +++ b/Documentation/DocBook/media/v4l/controls.xml > @@ -4370,6 +4370,24 @@ interface and may change in the future. > The flash controller has detected a short or open > circuit condition on the indicator LED. > > + > + V4L2_FLASH_FAULT_UNDER_VOLTAGE > + Flash controller voltage to the flash LED > + has been below the minimum limit specific to the flash > + controller. > + > + > + V4L2_FLASH_FAULT_INPUT_VOLTAGE > + The flash controller has detected adjustment by IVFM > + (Input Voltage Flash Monitor) block. > + If during the flash current turn-on, the input voltage falls > + below the threshold input voltage, IVFM adjust level Could you add an explanation what does this fault actually mean to the user? "IVFM" at least doesn't say anything to me... > + > + > + V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE > + The flash controller has detected that TEMP input has > + crossed threshold by external temperature sensor. How about this instead? "The temperature of the LED has exceeded its allowed upper limit." -- Kind regards, Sakari Ailus sakari.ailus@iki.fi