public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Theodore Kilgore <kilgota@banach.math.auburn.edu>,
	linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] gspca_stv06xx: remove an unneeded check
Date: Sun, 23 Feb 2014 22:47:50 +0100	[thread overview]
Message-ID: <530A6C86.6010707@redhat.com> (raw)
In-Reply-To: <20140218150044.GC6914@elgon.mountain>

Hi,

On 02/18/2014 04:00 PM, Dan Carpenter wrote:
> "err" is zero here so we don't need to check again.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> index bf3e5c317a26..e60cbb3aa609 100644
> --- a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> +++ b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
> @@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
>  
>  	PDEBUG(D_STREAM, "Halting stream");
>  
> -	return (err < 0) ? err : 0;
> +	return 0;
>  }
>  
>  static int vv6410_dump(struct sd *sd)
> 

Thanks I've added this to my gspca tree for 3.15.

Regards,

Hans

      reply	other threads:[~2014-02-23 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 15:00 [patch] [media] gspca_stv06xx: remove an unneeded check Dan Carpenter
2014-02-23 21:47 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530A6C86.6010707@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kilgota@banach.math.auburn.edu \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox