From: Daniel Jeong <gshark.jeong@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Rob Landley <rob@landley.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [RFC v5,2/3] controls.xml : add addtional Flash fault bits
Date: Mon, 24 Feb 2014 13:12:38 +0900 [thread overview]
Message-ID: <530AC6B6.4060000@gmail.com> (raw)
In-Reply-To: <53072326.7050809@iki.fi>
Hi Sakari
Thank you for your comments.
> Hi Daniel,
>
> Daniel Jeong wrote:
>> Added more comment about Input voltage flash monitor and external
>> temp function.
>>
>> Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
>> ---
>> Documentation/DocBook/media/v4l/controls.xml | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/DocBook/media/v4l/controls.xml
>> b/Documentation/DocBook/media/v4l/controls.xml
>> index a5a3188..145a127 100644
>> --- a/Documentation/DocBook/media/v4l/controls.xml
>> +++ b/Documentation/DocBook/media/v4l/controls.xml
>> @@ -4370,6 +4370,24 @@ interface and may change in the future.</para>
>> <entry>The flash controller has detected a short or open
>> circuit condition on the indicator LED.</entry>
>> </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
>> + <entry>Flash controller voltage to the flash LED
>> + has been below the minimum limit specific to the flash
>> + controller.</entry>
>> + </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
>> + <entry>The flash controller has detected adjustment by
>> IVFM
>> + (Input Voltage Flash Monitor) block.
>> + If during the flash current turn-on, the input voltage falls
>> + below the threshold input voltage, IVFM adjust level</entry>
>
> Could you add an explanation what does this fault actually mean to the
> user?
>
> "IVFM" at least doesn't say anything to me...
>
How about this ?
"The flash current can't reach to the target current due to the input
voltage falling below lower limit
and flash controller adjusted the flash current not to occur low voltage
envent"
>> + </row>
>> + <row>
>> +
>> <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
>> + <entry>The flash controller has detected that TEMP
>> input has
>> + crossed threshold by external temperature sensor.</entry>
>
> How about this instead?
>
> "The temperature of the LED has exceeded its allowed upper limit."
>
Ok.
prev parent reply other threads:[~2014-02-24 4:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 4:49 [RFC v5,2/3] controls.xml : add addtional Flash fault bits Daniel Jeong
2014-02-21 9:57 ` Sakari Ailus
2014-02-24 4:12 ` Daniel Jeong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530AC6B6.4060000@gmail.com \
--to=gshark.jeong@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rob@landley.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox