From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:50556 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752442AbaBXPcc (ORCPT ); Mon, 24 Feb 2014 10:32:32 -0500 Message-ID: <530B668D.6010903@iki.fi> Date: Mon, 24 Feb 2014 17:34:37 +0200 From: Sakari Ailus MIME-Version: 1.0 To: Hans Verkuil , linux-media@vger.kernel.org CC: laurent.pinchart@ideasonboard.com, k.debski@samsung.com Subject: Re: [PATCH v5 2/7] v4l: Use full 32 bits for buffer flags References: <1392497585-5084-1-git-send-email-sakari.ailus@iki.fi> <1392497585-5084-3-git-send-email-sakari.ailus@iki.fi> <5309E05E.4030108@xs4all.nl> In-Reply-To: <5309E05E.4030108@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hans Verkuil wrote: > On 02/15/2014 09:53 PM, Sakari Ailus wrote: >> The buffer flags field is 32 bits but the defined only used 16. This is >> fine, but as more than 16 bits will be used in the very near future, define >> them as 32-bit numbers for consistency. >> >> Signed-off-by: Sakari Ailus >> --- >> Documentation/DocBook/media/v4l/io.xml | 30 ++++++++++++------------- >> include/uapi/linux/videodev2.h | 38 +++++++++++++++++++------------- >> 2 files changed, 38 insertions(+), 30 deletions(-) >> >> diff --git a/Documentation/DocBook/media/v4l/io.xml b/Documentation/DocBook/media/v4l/io.xml >> index 8facac4..46d24b3 100644 >> --- a/Documentation/DocBook/media/v4l/io.xml >> +++ b/Documentation/DocBook/media/v4l/io.xml > > > >> @@ -1115,7 +1115,7 @@ in which case caches have not been used. >> >> >> V4L2_BUF_FLAG_TIMESTAMP_COPY >> - 0x4000 >> + 0x00004000 >> The CAPTURE buffer timestamp has been taken from the >> corresponding OUTPUT buffer. This flag applies only to mem2mem devices. >> > > Should we add here that if TIMESTAMP_COPY is set and the TIMECODE flag is set, > then drivers should copy the TIMECODE struct as well? This is happening already > in various drivers and I think that is appropriate. Although to be honest nobody > is actually using the timecode struct, but we plan to hijack that for hardware > timestamps in the future anyway. Is there a single driver which uses the timecode field? The fact is that many m2m drivers copy it but that's probably mostly copying what one of them happened to do by accident. :-) -- Sakari Ailus sakari.ailus@iki.fi