* [PATCH] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras
@ 2014-02-24 15:49 Phil Edworthy
2014-02-24 18:38 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Phil Edworthy @ 2014-02-24 15:49 UTC (permalink / raw)
To: linux-media
Cc: linux-sh, Valentine Barshak, Simon Horman, Magnus Damm,
Kuninori Morimoto, Laurent Pinchart, Mauro Carvalho Chehab,
Hans Verkuil, Guennadi Liakhovetski, Phil Edworthy
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
drivers/media/platform/soc_camera/rcar_vin.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index 3b1c05a..9929375 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -68,6 +68,8 @@
#define VNMC_YCAL (1 << 19)
#define VNMC_INF_YUV8_BT656 (0 << 16)
#define VNMC_INF_YUV8_BT601 (1 << 16)
+#define VNMC_INF_YUV10_BT656 (2 << 16)
+#define VNMC_INF_YUV10_BT601 (3 << 16)
#define VNMC_INF_YUV16 (5 << 16)
#define VNMC_VUP (1 << 10)
#define VNMC_IM_ODD (0 << 3)
@@ -275,6 +277,10 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
/* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
+ case V4L2_MBUS_FMT_YUYV10_2X10:
+ /* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */
+ vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
+ VNMC_INF_YUV10_BT656 : VNMC_INF_YUV10_BT601;
default:
break;
}
@@ -1003,6 +1009,7 @@ static int rcar_vin_get_formats(struct soc_camera_device *icd, unsigned int idx,
switch (code) {
case V4L2_MBUS_FMT_YUYV8_1X16:
case V4L2_MBUS_FMT_YUYV8_2X8:
+ case V4L2_MBUS_FMT_YUYV10_2X10:
if (cam->extra_fmt)
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras
2014-02-24 15:49 [PATCH] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras Phil Edworthy
@ 2014-02-24 18:38 ` Laurent Pinchart
2014-02-25 9:10 ` [PATCH v2] " Phil Edworthy
2014-02-25 13:40 ` [PATCH] " Valentine
0 siblings, 2 replies; 5+ messages in thread
From: Laurent Pinchart @ 2014-02-24 18:38 UTC (permalink / raw)
To: Phil Edworthy
Cc: linux-media, linux-sh, Valentine Barshak, Simon Horman,
Magnus Damm, Kuninori Morimoto, Mauro Carvalho Chehab,
Hans Verkuil, Guennadi Liakhovetski
Hi Phil,
Thank you for the patch.
On Monday 24 February 2014 15:49:05 Phil Edworthy wrote:
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> ---
> drivers/media/platform/soc_camera/rcar_vin.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
> b/drivers/media/platform/soc_camera/rcar_vin.c index 3b1c05a..9929375
> 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -68,6 +68,8 @@
> #define VNMC_YCAL (1 << 19)
> #define VNMC_INF_YUV8_BT656 (0 << 16)
> #define VNMC_INF_YUV8_BT601 (1 << 16)
> +#define VNMC_INF_YUV10_BT656 (2 << 16)
> +#define VNMC_INF_YUV10_BT601 (3 << 16)
> #define VNMC_INF_YUV16 (5 << 16)
> #define VNMC_VUP (1 << 10)
> #define VNMC_IM_ODD (0 << 3)
> @@ -275,6 +277,10 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
> /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
> vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
> VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
Aren't you missing a break here ?
> + case V4L2_MBUS_FMT_YUYV10_2X10:
> + /* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */
> + vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
> + VNMC_INF_YUV10_BT656 : VNMC_INF_YUV10_BT601;
You should add one here as well. Although not strictly necessary, it would
help to avoid making the same mistake again.
The rest looks good to me, but I'm not familiar with the hardware, so I'll let
Valentine have the last word.
> default:
> break;
> }
> @@ -1003,6 +1009,7 @@ static int rcar_vin_get_formats(struct
> soc_camera_device *icd, unsigned int idx, switch (code) {
> case V4L2_MBUS_FMT_YUYV8_1X16:
> case V4L2_MBUS_FMT_YUYV8_2X8:
> + case V4L2_MBUS_FMT_YUYV10_2X10:
> if (cam->extra_fmt)
> break;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras
2014-02-24 18:38 ` Laurent Pinchart
@ 2014-02-25 9:10 ` Phil Edworthy
2014-02-25 13:40 ` Vladimir Barinov
2014-02-25 13:40 ` [PATCH] " Valentine
1 sibling, 1 reply; 5+ messages in thread
From: Phil Edworthy @ 2014-02-25 9:10 UTC (permalink / raw)
To: linux-media
Cc: linux-sh, Valentine Barshak, Simon Horman, Magnus Damm,
Kuninori Morimoto, Laurent Pinchart, Mauro Carvalho Chehab,
Hans Verkuil, Guennadi Liakhovetski, Phil Edworthy
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
v2:
- Fix silly mistake with missing break.
drivers/media/platform/soc_camera/rcar_vin.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index 3b1c05a..702dc47 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -68,6 +68,8 @@
#define VNMC_YCAL (1 << 19)
#define VNMC_INF_YUV8_BT656 (0 << 16)
#define VNMC_INF_YUV8_BT601 (1 << 16)
+#define VNMC_INF_YUV10_BT656 (2 << 16)
+#define VNMC_INF_YUV10_BT601 (3 << 16)
#define VNMC_INF_YUV16 (5 << 16)
#define VNMC_VUP (1 << 10)
#define VNMC_IM_ODD (0 << 3)
@@ -275,6 +277,12 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
/* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
+ break;
+ case V4L2_MBUS_FMT_YUYV10_2X10:
+ /* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */
+ vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
+ VNMC_INF_YUV10_BT656 : VNMC_INF_YUV10_BT601;
+ break;
default:
break;
}
@@ -1003,6 +1011,7 @@ static int rcar_vin_get_formats(struct soc_camera_device *icd, unsigned int idx,
switch (code) {
case V4L2_MBUS_FMT_YUYV8_1X16:
case V4L2_MBUS_FMT_YUYV8_2X8:
+ case V4L2_MBUS_FMT_YUYV10_2X10:
if (cam->extra_fmt)
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras
2014-02-25 9:10 ` [PATCH v2] " Phil Edworthy
@ 2014-02-25 13:40 ` Vladimir Barinov
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Barinov @ 2014-02-25 13:40 UTC (permalink / raw)
To: Phil Edworthy
Cc: linux-media, linux-sh, Valentine Barshak, Simon Horman,
Magnus Damm, Kuninori Morimoto, Laurent Pinchart,
Mauro Carvalho Chehab, Hans Verkuil, Guennadi Liakhovetski
On 02/25/2014 01:10 PM, Phil Edworthy wrote:
> Signed-off-by: Phil Edworthy<phil.edworthy@renesas.com>
Acked-by: Vladimir Barinov<vladimir.barinov@cogentembedded.com>
(Valentine can't do the review atm)
> ---
> v2:
> - Fix silly mistake with missing break.
>
> drivers/media/platform/soc_camera/rcar_vin.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index 3b1c05a..702dc47 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -68,6 +68,8 @@
> #define VNMC_YCAL (1<< 19)
> #define VNMC_INF_YUV8_BT656 (0<< 16)
> #define VNMC_INF_YUV8_BT601 (1<< 16)
> +#define VNMC_INF_YUV10_BT656 (2<< 16)
> +#define VNMC_INF_YUV10_BT601 (3<< 16)
> #define VNMC_INF_YUV16 (5<< 16)
> #define VNMC_VUP (1<< 10)
> #define VNMC_IM_ODD (0<< 3)
> @@ -275,6 +277,12 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
> /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
> vnmc |= priv->pdata->flags& RCAR_VIN_BT656 ?
> VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
> + break;
> + case V4L2_MBUS_FMT_YUYV10_2X10:
> + /* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */
> + vnmc |= priv->pdata->flags& RCAR_VIN_BT656 ?
> + VNMC_INF_YUV10_BT656 : VNMC_INF_YUV10_BT601;
> + break;
> default:
> break;
> }
> @@ -1003,6 +1011,7 @@ static int rcar_vin_get_formats(struct soc_camera_device *icd, unsigned int idx,
> switch (code) {
> case V4L2_MBUS_FMT_YUYV8_1X16:
> case V4L2_MBUS_FMT_YUYV8_2X8:
> + case V4L2_MBUS_FMT_YUYV10_2X10:
> if (cam->extra_fmt)
> break;
>
Regards,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras
2014-02-24 18:38 ` Laurent Pinchart
2014-02-25 9:10 ` [PATCH v2] " Phil Edworthy
@ 2014-02-25 13:40 ` Valentine
1 sibling, 0 replies; 5+ messages in thread
From: Valentine @ 2014-02-25 13:40 UTC (permalink / raw)
To: Laurent Pinchart, Phil Edworthy
Cc: linux-media, linux-sh, Simon Horman, Magnus Damm,
Kuninori Morimoto, Mauro Carvalho Chehab, Hans Verkuil,
Guennadi Liakhovetski
On 02/24/2014 10:38 PM, Laurent Pinchart wrote:
> Hi Phil,
>
> Thank you for the patch.
>
> On Monday 24 February 2014 15:49:05 Phil Edworthy wrote:
>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
>> ---
>> drivers/media/platform/soc_camera/rcar_vin.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
>> b/drivers/media/platform/soc_camera/rcar_vin.c index 3b1c05a..9929375
>> 100644
>> --- a/drivers/media/platform/soc_camera/rcar_vin.c
>> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
>> @@ -68,6 +68,8 @@
>> #define VNMC_YCAL (1 << 19)
>> #define VNMC_INF_YUV8_BT656 (0 << 16)
>> #define VNMC_INF_YUV8_BT601 (1 << 16)
>> +#define VNMC_INF_YUV10_BT656 (2 << 16)
>> +#define VNMC_INF_YUV10_BT601 (3 << 16)
>> #define VNMC_INF_YUV16 (5 << 16)
>> #define VNMC_VUP (1 << 10)
>> #define VNMC_IM_ODD (0 << 3)
>> @@ -275,6 +277,10 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
>> /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */
>> vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
>> VNMC_INF_YUV8_BT656 : VNMC_INF_YUV8_BT601;
>
> Aren't you missing a break here ?
>
>> + case V4L2_MBUS_FMT_YUYV10_2X10:
>> + /* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */
>> + vnmc |= priv->pdata->flags & RCAR_VIN_BT656 ?
>> + VNMC_INF_YUV10_BT656 : VNMC_INF_YUV10_BT601;
>
> You should add one here as well. Although not strictly necessary, it would
> help to avoid making the same mistake again.
>
> The rest looks good to me, but I'm not familiar with the hardware, so I'll let
> Valentine have the last word.
Thanks, looks good to me.
>
>> default:
>> break;
>> }
>> @@ -1003,6 +1009,7 @@ static int rcar_vin_get_formats(struct
>> soc_camera_device *icd, unsigned int idx, switch (code) {
>> case V4L2_MBUS_FMT_YUYV8_1X16:
>> case V4L2_MBUS_FMT_YUYV8_2X8:
>> + case V4L2_MBUS_FMT_YUYV10_2X10:
>> if (cam->extra_fmt)
>> break;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-25 13:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-24 15:49 [PATCH] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras Phil Edworthy
2014-02-24 18:38 ` Laurent Pinchart
2014-02-25 9:10 ` [PATCH v2] " Phil Edworthy
2014-02-25 13:40 ` Vladimir Barinov
2014-02-25 13:40 ` [PATCH] " Valentine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox